From: snitzer@sourceware.org <snitzer@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/activate/dev_manager.c
Date: 8 Feb 2010 23:28:07 -0000 [thread overview]
Message-ID: <20100208232807.5477.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: snitzer at sourceware.org 2010-02-08 23:28:06
Modified files:
. : WHATS_NEW
lib/activate : dev_manager.c
Log message:
Remove false "failed to find tree node for <lv>" error from _cached_info().
When activating a merging origin it is valid, and expected, to not have
a node in the deptree for both the origin and its merging snapshot. The
_cached_info() caller is only concerned with whether a device is open.
If there isn't a node in the tree the associated device is definitely
not open.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1423&r2=1.1424
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/dev_manager.c.diff?cvsroot=lvm2&r1=1.178&r2=1.179
--- LVM2/WHATS_NEW 2010/02/06 07:44:16 1.1423
+++ LVM2/WHATS_NEW 2010/02/08 23:28:06 1.1424
@@ -1,5 +1,6 @@
Version 2.02.61 -
===================================
+ Remove false "failed to find tree node for" error when activating merging origin.
Make lvconvert --repair --use-policies exit with success when no action is needed.
Add multiple snapshot lv 'lvconvert --merge @tag' support via process_each_lv().
Fix inappropriate second resync when adding mimage to core-logged mirror.
--- LVM2/lib/activate/dev_manager.c 2010/01/26 07:58:23 1.178
+++ LVM2/lib/activate/dev_manager.c 2010/02/08 23:28:06 1.179
@@ -264,10 +264,9 @@
return NULL;
}
- if (!(dnode = dm_tree_find_node_by_uuid(dtree, dlid))) {
- log_error("failed to find tree node for %s", lv->name);
+ /* An activating merging origin won't have a node in the tree yet */
+ if (!(dnode = dm_tree_find_node_by_uuid(dtree, dlid)))
return NULL;
- }
if (!(dinfo = dm_tree_node_get_info(dnode))) {
log_error("failed to get info from tree node for %s", lv->name);
next reply other threads:[~2010-02-08 23:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 23:28 snitzer [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 12:50 LVM2 ./WHATS_NEW lib/activate/dev_manager.c agk
2012-04-20 14:17 jbrassow
2012-03-05 14:15 zkabelac
2012-02-01 13:47 zkabelac
2012-01-28 20:12 zkabelac
2012-01-23 20:56 jbrassow
2012-01-20 21:56 snitzer
2011-12-21 12:59 zkabelac
2011-11-18 19:42 zkabelac
2011-10-11 8:59 zkabelac
2011-10-11 8:57 zkabelac
2011-08-11 4:18 jbrassow
2011-07-06 0:29 agk
2011-07-05 23:10 agk
2011-01-05 14:03 zkabelac
2010-12-08 19:26 agk
2010-10-25 10:37 agk
2010-10-24 17:36 snitzer
2010-08-26 14:21 jbrassow
2010-08-17 1:51 agk
2010-08-03 13:13 zkabelac
2010-05-24 9:01 zkabelac
2010-05-21 14:47 zkabelac
2010-01-26 7:58 mbroz
2010-01-22 15:40 snitzer
2009-08-03 18:09 agk
2009-05-28 1:11 agk
2009-05-13 14:13 zkabelac
2008-12-19 15:23 mbroz
2008-06-05 12:45 agk
2007-05-14 11:27 mbroz
2007-03-08 19:58 agk
2006-11-20 16:45 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208232807.5477.qmail@sourceware.org \
--to=snitzer@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.