* [PATCH] MIPS: Don't probe reserved EntryHi bits.
@ 2010-02-08 20:27 David Daney
2010-02-08 20:36 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: David Daney @ 2010-02-08 20:27 UTC (permalink / raw)
To: linux-mips, ralf; +Cc: David Daney, Guenter Roeck
The patch that adds cpu_probe_vmbits is erroneously writing to
reserved bit 12. Since we are really only probing high bits, don't
write this bit with a one.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Guenter Roeck <guenter.roeck@ericsson.com>
---
arch/mips/kernel/cpu-probe.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index 2ff5f64..9ea5ca8 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c
@@ -287,9 +287,9 @@ static inline int __cpu_has_fpu(void)
static inline void cpu_probe_vmbits(struct cpuinfo_mips *c)
{
#ifdef __NEED_VMBITS_PROBE
- write_c0_entryhi(0x3ffffffffffff000ULL);
+ write_c0_entryhi(0x3fffffffffffe000ULL);
back_to_back_c0_hazard();
- c->vmbits = fls64(read_c0_entryhi() & 0x3ffffffffffff000ULL);
+ c->vmbits = fls64(read_c0_entryhi() & 0x3fffffffffffe000ULL);
#endif
}
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Don't probe reserved EntryHi bits.
2010-02-08 20:27 [PATCH] MIPS: Don't probe reserved EntryHi bits David Daney
@ 2010-02-08 20:36 ` Guenter Roeck
2010-02-09 13:17 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2010-02-08 20:36 UTC (permalink / raw)
To: David Daney; +Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
On Mon, 2010-02-08 at 15:27 -0500, David Daney wrote:
> The patch that adds cpu_probe_vmbits is erroneously writing to
> reserved bit 12. Since we are really only probing high bits, don't
> write this bit with a one.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> CC: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> arch/mips/kernel/cpu-probe.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
> index 2ff5f64..9ea5ca8 100644
> --- a/arch/mips/kernel/cpu-probe.c
> +++ b/arch/mips/kernel/cpu-probe.c
> @@ -287,9 +287,9 @@ static inline int __cpu_has_fpu(void)
> static inline void cpu_probe_vmbits(struct cpuinfo_mips *c)
> {
> #ifdef __NEED_VMBITS_PROBE
> - write_c0_entryhi(0x3ffffffffffff000ULL);
> + write_c0_entryhi(0x3fffffffffffe000ULL);
> back_to_back_c0_hazard();
> - c->vmbits = fls64(read_c0_entryhi() & 0x3ffffffffffff000ULL);
> + c->vmbits = fls64(read_c0_entryhi() & 0x3fffffffffffe000ULL);
> #endif
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Don't probe reserved EntryHi bits.
2010-02-08 20:36 ` Guenter Roeck
@ 2010-02-09 13:17 ` Ralf Baechle
0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2010-02-09 13:17 UTC (permalink / raw)
To: Guenter Roeck; +Cc: David Daney, linux-mips@linux-mips.org
On Mon, Feb 08, 2010 at 12:36:28PM -0800, Guenter Roeck wrote:
> On Mon, 2010-02-08 at 15:27 -0500, David Daney wrote:
> > The patch that adds cpu_probe_vmbits is erroneously writing to
> > reserved bit 12. Since we are really only probing high bits, don't
> > write this bit with a one.
> >
> > Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> > CC: Guenter Roeck <guenter.roeck@ericsson.com>
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: you meant. Patch applied.
Thanks folks,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-09 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-08 20:27 [PATCH] MIPS: Don't probe reserved EntryHi bits David Daney
2010-02-08 20:36 ` Guenter Roeck
2010-02-09 13:17 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.