From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Colin McCabe <cmccabe@alumni.cmu.edu>,
Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [PATCHv2] cld: use XDR for all messages
Date: Tue, 9 Feb 2010 17:21:57 -0700 [thread overview]
Message-ID: <20100209172157.509ffdb9@redhat.com> (raw)
In-Reply-To: <4B71EDDE.6070209@garzik.org>
On Tue, 09 Feb 2010 18:21:02 -0500
Jeff Garzik <jeff@garzik.org> wrote:
> So, the programs themselves have it right -- debug/verbose is an integer
> not a bool. The internal libraries get that wrong sometimes, though.
>
> Having separate knobs for 'debug' and 'verbose' will be more confusing
> than a single control, IMO.
I dunno, I think bigger packages tend to drift towards bitmasks.
But I don't have a strong opinion. I just wanted to restore the
per-packet output that you wanted. If you think that an integer is
better, that's fine. The newer code should is more regular and easier
to mold in any desired way.
Actually, I think the whole idea of debug levels is flawed.
We should work on adding a CLD protocol dissector to Wireshark
instead, now that with Colin's help we've settled to a protocol.
-- Pete
next prev parent reply other threads:[~2010-02-10 0:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 17:49 [PATCHv2] cld: use XDR for all messages Colin McCabe
2010-01-21 1:38 ` Jeff Garzik
2010-01-21 2:38 ` Colin McCabe
2010-01-26 21:22 ` Colin McCabe
2010-01-26 22:11 ` Jeff Garzik
2010-01-26 23:47 ` Colin McCabe
2010-01-29 7:01 ` Jeff Garzik
2010-01-30 1:01 ` Colin McCabe
2010-02-03 6:35 ` [PATCH] " Jeff Garzik
2010-02-03 21:45 ` Colin McCabe
2010-02-05 9:51 ` Jeff Garzik
2010-02-05 0:59 ` Jeff Garzik
2010-02-05 4:14 ` Pete Zaitcev
2010-02-05 6:06 ` Jeff Garzik
2010-02-05 7:16 ` Pete Zaitcev
2010-02-05 9:48 ` Jeff Garzik
2010-02-05 18:49 ` Colin McCabe
2010-02-09 9:20 ` Jeff Garzik
2010-02-09 9:38 ` Jeff Garzik
2010-02-09 15:47 ` Pete Zaitcev
2010-02-09 23:13 ` Pete Zaitcev
2010-02-09 23:21 ` Jeff Garzik
2010-02-10 0:21 ` Pete Zaitcev [this message]
2010-02-10 1:33 ` Jeff Garzik
2010-02-10 2:27 ` Colin McCabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209172157.509ffdb9@redhat.com \
--to=zaitcev@redhat.com \
--cc=cmccabe@alumni.cmu.edu \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.