[PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error

[PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error

[Sukadev Bhattiprolu]

From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Tue, 9 Feb 2010 11:08:22 -0800
Subject: [PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error

If the fcntl tests (filelock[12], filelease1 and fsetown1) fail during
checkpoint, the processes end up frozen and appear hung.  Thaw the
processes and terminate them before exiting the script.

Bug reported by Serge Hallyn.

Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 fileio/run-fcntltests.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fileio/run-fcntltests.sh b/fileio/run-fcntltests.sh
index f76c942..35be131 100755
--- a/fileio/run-fcntltests.sh
+++ b/fileio/run-fcntltests.sh
@@ -54,6 +54,8 @@ checkpoint()
 	if [ $ret -ne 0 ]; then
 		$ECHO "***** FAIL: Checkpoint of $pid failed"
 		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
+		killall -9 `basename $TEST_CMD`
+		thaw
 		exit 1;
 	fi
 }
-- 
1.6.6.1

Re: [PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error

[Serge E. Hallyn]

Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org):
> From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Date: Tue, 9 Feb 2010 11:08:22 -0800
> Subject: [PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error
> 
> If the fcntl tests (filelock[12], filelease1 and fsetown1) fail during
> checkpoint, the processes end up frozen and appear hung.  Thaw the
> processes and terminate them before exiting the script.
> 
> Bug reported by Serge Hallyn.

Thanks, will push this and the eclone tests.

> Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
>  fileio/run-fcntltests.sh |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fileio/run-fcntltests.sh b/fileio/run-fcntltests.sh
> index f76c942..35be131 100755
> --- a/fileio/run-fcntltests.sh
> +++ b/fileio/run-fcntltests.sh
> @@ -54,6 +54,8 @@ checkpoint()
>  	if [ $ret -ne 0 ]; then
>  		$ECHO "***** FAIL: Checkpoint of $pid failed"
>  		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
> +		killall -9 `basename $TEST_CMD`
> +		thaw
>  		exit 1;
>  	fi
>  }
> -- 
> 1.6.6.1