From: tytso@mit.edu
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V2] mke2fs: account for physical as well as logical sector size
Date: Tue, 9 Feb 2010 17:21:55 -0500 [thread overview]
Message-ID: <20100209222155.GB739@thunk.org> (raw)
In-Reply-To: <4B70914B.3000102@redhat.com>
On Mon, Feb 08, 2010 at 04:33:47PM -0600, Eric Sandeen wrote:
> Some devices, notably 4k sector drives, may have a 512 logical
> sector size, mapped onto a 4k physical sector size.
>
> When mke2fs is ratcheting down the blocksize for small filesystems,
> or when a blocksize is specified on the commandline, we should not
> willingly go below the physical sector size of the device.
>
> When a blocksize is specified, we -must- not go below
> the logical sector size of the device.
>
> Add a new library function, ext2fs_get_device_phys_sectsize()
> to get the physical sector size if possible, and adjust the
> logic in mke2fs to enforce the above rules.
Was this something you think is worth trying to slip into 1.41.10?
Just checking... my default is to defer this unless you think its
especially important.
- Ted
next prev parent reply other threads:[~2010-02-09 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 22:31 [PATCH] libext2fs: try to get physical sector size first in ext2fs_get_device_sectsize() Eric Sandeen
2010-02-08 22:33 ` [PATCH V2] mke2fs: account for physical as well as logical sector size Eric Sandeen
2010-02-09 22:21 ` tytso [this message]
2010-02-09 22:23 ` Eric Sandeen
2010-05-17 21:44 ` Eric Sandeen
2010-05-18 2:35 ` tytso
2010-05-18 3:12 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209222155.GB739@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.