Re: [PATCH V2] mke2fs: account for physical as well as logical sector size

[Eric Sandeen <sandeen@redhat.com>]

tytso@mit.edu wrote:
> On Mon, Feb 08, 2010 at 04:33:47PM -0600, Eric Sandeen wrote:
>> Some devices, notably 4k sector drives, may have a 512 logical
>> sector size, mapped onto a 4k physical sector size.
>>
>> When mke2fs is ratcheting down the blocksize for small filesystems,
>> or when a blocksize is specified on the commandline, we should not
>> willingly go below the physical sector size of the device.
>>
>> When a blocksize is specified, we -must- not go below
>> the logical sector size of the device.
>>
>> Add a new library function, ext2fs_get_device_phys_sectsize()
>> to get the physical sector size if possible, and adjust the
>> logic in mke2fs to enforce the above rules.
> 
> Was this something you think is worth trying to slip into 1.41.10?
> 
> Just checking... my default is to defer this unless you think its
> especially important.
> 
> 						- Ted


I'm inclined to defer it.  I can get it in as a patch if we need to.

I'd meant to send it earlier but well, you know ... ;)

Thanks,
-Eric