All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: linux-nfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [RFC PATCH 2/2] xfs_export_operations.commit_metadata
Date: Wed, 10 Feb 2010 05:11:30 -0500	[thread overview]
Message-ID: <20100210101130.GA7993@infradead.org> (raw)
In-Reply-To: <20100210090750.GB21875@infradead.org>

On Wed, Feb 10, 2010 at 04:07:50AM -0500, Christoph Hellwig wrote:
> > +			/*
> > +			 * AFAICS the child is always modified after the parent
> > +			 * in nfsd so should always have a larger lsn.
> > +			 */
> > +			if (c_xip->i_itemp->ili_last_lsn > force_lsn) {
> > +				force_lsn = c_xip->i_itemp->ili_last_lsn;
> > +			} else {
> > +				force_lsn = 0; /* whole thing */
> > +			}
> 
> I wouldn't rely on that and always take the larger one.

Or we could use that fact for making the prototype saner:

 - the commit_metadata only takes a single inode to force out
 - we make sure to always call in on the child first.  For any
   log based filesystem that will force the parent update, too.
 - we then call it on the parent, which will be a no-op and thus
   fast for a log based filesystem, but still provide a fallback
   if that is not the case.


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: linux-nfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [RFC PATCH 2/2] xfs_export_operations.commit_metadata
Date: Wed, 10 Feb 2010 05:11:30 -0500	[thread overview]
Message-ID: <20100210101130.GA7993@infradead.org> (raw)
In-Reply-To: <20100210090750.GB21875@infradead.org>

On Wed, Feb 10, 2010 at 04:07:50AM -0500, Christoph Hellwig wrote:
> > +			/*
> > +			 * AFAICS the child is always modified after the parent
> > +			 * in nfsd so should always have a larger lsn.
> > +			 */
> > +			if (c_xip->i_itemp->ili_last_lsn > force_lsn) {
> > +				force_lsn = c_xip->i_itemp->ili_last_lsn;
> > +			} else {
> > +				force_lsn = 0; /* whole thing */
> > +			}
> 
> I wouldn't rely on that and always take the larger one.

Or we could use that fact for making the prototype saner:

 - the commit_metadata only takes a single inode to force out
 - we make sure to always call in on the child first.  For any
   log based filesystem that will force the parent update, too.
 - we then call it on the parent, which will be a no-op and thus
   fast for a log based filesystem, but still provide a fallback
   if that is not the case.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-02-10 10:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  0:33 [RFC PATCH 0/2] nfsd sync export_op (was 'wsync export option') Ben Myers
2010-02-10  0:33 ` [RFC PATCH 1/2] commit_metadata export operation and nfsd_sync2 Ben Myers
2010-02-10  8:56   ` Christoph Hellwig
2010-02-10 19:53     ` bpm
2010-02-10 21:56       ` Christoph Hellwig
2010-02-10  0:33 ` [RFC PATCH 2/2] xfs_export_operations.commit_metadata Ben Myers
2010-02-10  9:07   ` Christoph Hellwig
2010-02-10  9:07     ` Christoph Hellwig
2010-02-10 10:11     ` Christoph Hellwig [this message]
2010-02-10 10:11       ` Christoph Hellwig
2010-02-10 20:15     ` bpm
2010-02-10 20:15       ` bpm
2010-02-10 21:29       ` Dave Chinner
2010-02-10 21:57       ` Christoph Hellwig
2010-02-10 21:57         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210101130.GA7993@infradead.org \
    --to=hch@infradead.org \
    --cc=bpm@sgi.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.