From: Evgeniy Polyakov <zbr@ioremap.net>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs
Date: Wed, 10 Feb 2010 13:12:46 +0300 [thread overview]
Message-ID: <20100210101246.GA3509@ioremap.net> (raw)
In-Reply-To: <20100210100428.GL30031@ZenIV.linux.org.uk>
On Wed, Feb 10, 2010 at 10:04:28AM +0000, Al Viro (viro@ZenIV.linux.org.uk) wrote:
> a) pohmelfs_construct_path_string() will do interesting things if you
> call it while chrooted into jail and pohmelfs mounted deeper in that
> jail. Try it.
Should it walk upto mountpoint?
> b) just why do we care about root of chroot jail in pohmelfs_path_length()?
> Not to mention anything else, current->fs->root/mnt may be changed under
> you if you share current->fs with another thread, but even aside of that,
> why does filesystem care about chroot of caller at all?
>
> What's going on there?
It tries to construct a full path upto mountpoint. Effectively it should
do similar to non-exported dentry_path() things. There is a race between
getting buffer size and filling with the actual path, but we take care
about that by restarting if needed.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2010-02-10 10:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 10:04 [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs Al Viro
2010-02-10 10:12 ` Evgeniy Polyakov [this message]
2010-02-10 10:24 ` Al Viro
2010-02-10 10:45 ` Evgeniy Polyakov
2010-02-10 11:00 ` Al Viro
2010-02-10 11:11 ` Evgeniy Polyakov
2010-02-10 11:59 ` Al Viro
2010-02-10 13:30 ` Evgeniy Polyakov
2010-02-10 21:02 ` Al Viro
2010-02-10 21:29 ` Evgeniy Polyakov
2010-02-11 3:02 ` Al Viro
2010-02-11 15:08 ` Evgeniy Polyakov
2010-02-11 17:10 ` Al Viro
2010-02-11 19:13 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210101246.GA3509@ioremap.net \
--to=zbr@ioremap.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.