From: Al Viro <viro@ZenIV.linux.org.uk>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs
Date: Wed, 10 Feb 2010 11:00:11 +0000 [thread overview]
Message-ID: <20100210110011.GN30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100210104515.GA6207@ioremap.net>
On Wed, Feb 10, 2010 at 01:45:15PM +0300, Evgeniy Polyakov wrote:
> > To mountpoint or to fs root? And what's going on with d_find_alias()?
>
> To root if it happend to be under mountpoint.
HUH? How the hell can root of filesystem be under the mountpoint of
that filesystem? What are you talking about?
> > AFAICS, you are doing that for regular files as well as directories,
> > and you do support link(2) in there, so dentry (and path) obtained from
> > that will be random.
>
> Not exactly random, but can change.
> Links support is rather subtle because of that, yes.
>
> Plan was to add external attribute or increase inode size to include
> parent name, but when I coded that it was so messy in respect of
> renames, that was dropped.
Why not use the dentries you've been given by VFS?
next prev parent reply other threads:[~2010-02-10 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 10:04 [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs Al Viro
2010-02-10 10:12 ` Evgeniy Polyakov
2010-02-10 10:24 ` Al Viro
2010-02-10 10:45 ` Evgeniy Polyakov
2010-02-10 11:00 ` Al Viro [this message]
2010-02-10 11:11 ` Evgeniy Polyakov
2010-02-10 11:59 ` Al Viro
2010-02-10 13:30 ` Evgeniy Polyakov
2010-02-10 21:02 ` Al Viro
2010-02-10 21:29 ` Evgeniy Polyakov
2010-02-11 3:02 ` Al Viro
2010-02-11 15:08 ` Evgeniy Polyakov
2010-02-11 17:10 ` Al Viro
2010-02-11 19:13 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210110011.GN30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.