From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [WARNING] mxc_w1_probe should not be __init modified
Date: Fri, 12 Feb 2010 12:01:00 +0100 [thread overview]
Message-ID: <20100212110100.GA18221@pengutronix.de> (raw)
In-Reply-To: <1265971348.2484.63.camel@realization>
Hello,
On Fri, Feb 12, 2010 at 11:42:28AM +0100, Alberto Panizzo wrote:
> Today linux-next build, report this:
>
> WARNING: drivers/w1/masters/built-in.o(.data+0x0): Section mismatch in reference from the variable mxc_w1_driver to the function .init.text:mxc_w1_probe()
> The variable mxc_w1_driver references
> the function __init mxc_w1_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
>
> I don't know if should be modified with __devinit instead or nothing at all.
Yes it should use __devinit. If you need a reason, try
cd /sys/bus/platform/drivers/mxc_w1
echo -n mxc_w1.0 > unbind
echo -n mxc_w1.0 > bind
While at it, mxc_w1_remove can be moved to devexit.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Alberto Panizzo <maramaopercheseimorto@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [WARNING] mxc_w1_probe should not be __init modified
Date: Fri, 12 Feb 2010 12:01:00 +0100 [thread overview]
Message-ID: <20100212110100.GA18221@pengutronix.de> (raw)
In-Reply-To: <1265971348.2484.63.camel@realization>
Hello,
On Fri, Feb 12, 2010 at 11:42:28AM +0100, Alberto Panizzo wrote:
> Today linux-next build, report this:
>
> WARNING: drivers/w1/masters/built-in.o(.data+0x0): Section mismatch in reference from the variable mxc_w1_driver to the function .init.text:mxc_w1_probe()
> The variable mxc_w1_driver references
> the function __init mxc_w1_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
>
> I don't know if should be modified with __devinit instead or nothing at all.
Yes it should use __devinit. If you need a reason, try
cd /sys/bus/platform/drivers/mxc_w1
echo -n mxc_w1.0 > unbind
echo -n mxc_w1.0 > bind
While at it, mxc_w1_remove can be moved to devexit.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-02-12 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 10:42 [WARNING] mxc_w1_probe should not be __init modified Alberto Panizzo
2010-02-12 10:42 ` Alberto Panizzo
2010-02-12 11:01 ` Uwe Kleine-König [this message]
2010-02-12 11:01 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212110100.GA18221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.