Re: [LTP] "pidns17" problem in "2010-02-11" cvs

["Serge E. Hallyn" <serue@us.ibm.com>]

Quoting Mitani (mitani@ryobi.co.jp):
> Hi,
> 
> I tried to test with "2010-02-11" cvs in RHEL5.4 system.
> But the test brings termination of connection.
> 
> I examined the phenomenon and discovered that "pidns17" test made 
> accident and sshd stopped after the test.
> 
> 
> I had some problems.
> 
> 1. I think that "tst_exit()" must be added last of "cleanup()"
>    function.
> ============
> --- ./testcases/kernel/containers/pidns/pidns17.c       2009-12-07
> 05:55:16.000000000 +0900
> +++ ./testcases/kernel/containers/pidns/pidns17.c.new   2010-02-12
> 16:26:31.000000000 +0900
> @@ -104,7 +104,6 @@
> 
>         /* cleanup and exit */
>         CLEANUP();
> -       tst_exit();
>  }
> 
>  /***********************************************************************
> @@ -136,7 +135,6 @@
> 
>         /* cleanup and exit */
>         CLEANUP();
> -       tst_exit();
>  }      /* End main */
> 
>  /*
> @@ -147,4 +145,5 @@
>  {
>         /* Clean the test testcase as LTP wants*/
>         TEST_CLEANUP;
> +       tst_exit();
>  }

Yeah I'm afraid I don't understand what CLEANUP and tst_exit exactly
do.  Hopefully Garrett can give an educated answer.

> ============
> 
> After revision, connection termination didn't occur.
> 
> 
> 2. I cannot understand the purpose that "kill()" function whose 
>    first parameter is "-1" is called.
> ------------
>         if (kill(-1, SIGUSR1) == -1) {
>                 tst_resm(TBROK | TERRNO, "cinit: kill(-1, SIGUSR1) failed");
>                 CLEANUP();
>         }
> ------------
> 
> If kill()'s first option is "-1", "man kill" says that
> "All processes with pid larger than 1 will be signaled."

Right, the test is checking whether kill -1 inside a private pidns
kills all processes besides init in the pid namespace.

> Therefore, not only the "sshd" but also the other processes were 
> affected, I think.

sshd is not in the private pid namespace and should not be killed.
If it is being killed by the pid -1 inside the container, then there
is a kernel bug.

> I'm glad if I could get some opinions.
> 
> 
> Thank you--
> 
> 
> -Tomonori Mitani

Thanks for testing.

-serge

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list