Re: [LTP] "pidns17" problem in "2010-02-11" cvs

["Serge E. Hallyn" <serue@us.ibm.com>]

Quoting Garrett Cooper (yanegomi@gmail.com):
> On Fri, Feb 12, 2010 at 9:51 AM, Serge E. Hallyn <serue@us.ibm.com> wrote:
> > Quoting Mitani (mitani@ryobi.co.jp):
> >> Hi,
> >>
> >> I tried to test with "2010-02-11" cvs in RHEL5.4 system.
> >> But the test brings termination of connection.
> >>
> >> I examined the phenomenon and discovered that "pidns17" test made
> >> accident and sshd stopped after the test.
> >>
> >>
> >> I had some problems.
> >>
> >> 1. I think that "tst_exit()" must be added last of "cleanup()"
> >>    function.
> >> ============
> >> --- ./testcases/kernel/containers/pidns/pidns17.c       2009-12-07
> >> 05:55:16.000000000 +0900
> >> +++ ./testcases/kernel/containers/pidns/pidns17.c.new   2010-02-12
> >> 16:26:31.000000000 +0900
> >> @@ -104,7 +104,6 @@
> >>
> >>         /* cleanup and exit */
> >>         CLEANUP();
> >> -       tst_exit();
> >>  }
> >>
> >>  /***********************************************************************
> >> @@ -136,7 +135,6 @@
> >>
> >>         /* cleanup and exit */
> >>         CLEANUP();
> >> -       tst_exit();
> >>  }      /* End main */
> >>
> >>  /*
> >> @@ -147,4 +145,5 @@
> >>  {
> >>         /* Clean the test testcase as LTP wants*/
> >>         TEST_CLEANUP;
> >> +       tst_exit();
> >>  }
> >
> > Yeah I'm afraid I don't understand what CLEANUP and tst_exit exactly
> > do.  Hopefully Garrett can give an educated answer.
> 
> Mitani's correct -- this is what should be done... CLEANUP is a
> constant that maps to cleanup in the event that tst_brkm is called,
> because linux_syscall_numbers.h's copy of syscall calls tst_brkm
> internally if ENOSYS is returned...

Cool, thanks

-serge

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list