* [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
@ 2010-02-14 10:54 Erik Andren
2010-02-14 15:47 ` Andreas Mohr
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Erik Andren @ 2010-02-14 10:54 UTC (permalink / raw)
To: mjg; +Cc: linux-kernel, linux-pm, Erik Andren
The Latitude C640 has another variation of dell in its DMI vendor entry.
Add it to the whitelist in order to enjoy the sweet fruits of software backlight toggling.
Signed-off-by: Erik Andren <erik.andren@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 3780994..b5246f1 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -79,6 +79,13 @@ static const struct dmi_system_id __initdata dell_device_table[] = {
DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
},
},
+ {
+ .ident = "Dell Computer Corporation",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
+ },
+ },
{ }
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 10:54 [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist Erik Andren
@ 2010-02-14 15:47 ` Andreas Mohr
2010-02-14 15:47 ` Andreas Mohr
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Andreas Mohr @ 2010-02-14 15:47 UTC (permalink / raw)
To: Erik Andren; +Cc: linux-pm, linux-kernel, mjg
> The Latitude C640 has another variation of dell in its DMI vendor entry.
> Add it to the whitelist in order to enjoy the sweet fruits of software
> backlight toggling.
Definitely not only this one. E.g. my Inspiron 8000 (P3/700) has (dmidecode):
Handle 0x0300, DMI type 3, 13 bytes
Chassis Information
Manufacturer: Dell Computer Corporation
Type: Portable
which, if "Portable" happens to be "8", means that it would match.
So:
- do all older matching machines grok this?
- if not, do something about it? ;)
[I should probably just offer myself to be a guinea pig]
Thanks for a very interesting piece of work!
Andreas Mohr
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 10:54 [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist Erik Andren
2010-02-14 15:47 ` Andreas Mohr
@ 2010-02-14 15:47 ` Andreas Mohr
2010-02-14 16:57 ` Matthew Garrett
2010-02-14 16:57 ` Matthew Garrett
2010-02-14 16:55 ` Matthew Garrett
2010-02-14 16:55 ` Matthew Garrett
3 siblings, 2 replies; 14+ messages in thread
From: Andreas Mohr @ 2010-02-14 15:47 UTC (permalink / raw)
To: Erik Andren; +Cc: mjg, linux-kernel, linux-pm
> The Latitude C640 has another variation of dell in its DMI vendor entry.
> Add it to the whitelist in order to enjoy the sweet fruits of software
> backlight toggling.
Definitely not only this one. E.g. my Inspiron 8000 (P3/700) has (dmidecode):
Handle 0x0300, DMI type 3, 13 bytes
Chassis Information
Manufacturer: Dell Computer Corporation
Type: Portable
which, if "Portable" happens to be "8", means that it would match.
So:
- do all older matching machines grok this?
- if not, do something about it? ;)
[I should probably just offer myself to be a guinea pig]
Thanks for a very interesting piece of work!
Andreas Mohr
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 15:47 ` Andreas Mohr
@ 2010-02-14 16:57 ` Matthew Garrett
2010-02-14 16:57 ` Matthew Garrett
1 sibling, 0 replies; 14+ messages in thread
From: Matthew Garrett @ 2010-02-14 16:57 UTC (permalink / raw)
To: Andreas Mohr; +Cc: linux-pm, Erik Andren, linux-kernel
On Sun, Feb 14, 2010 at 04:47:10PM +0100, Andreas Mohr wrote:
> Definitely not only this one. E.g. my Inspiron 8000 (P3/700) has (dmidecode):
>
> Handle 0x0300, DMI type 3, 13 bytes
> Chassis Information
> Manufacturer: Dell Computer Corporation
> Type: Portable
>
> which, if "Portable" happens to be "8", means that it would match.
8 should be portable, yes. 9 would be laptop (and 10 notebook), but I
haven't seen any examples of those in Dells.
> So:
> - do all older matching machines grok this?
The dcdbas call should fail if they don't, so I think we're ok.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 15:47 ` Andreas Mohr
2010-02-14 16:57 ` Matthew Garrett
@ 2010-02-14 16:57 ` Matthew Garrett
1 sibling, 0 replies; 14+ messages in thread
From: Matthew Garrett @ 2010-02-14 16:57 UTC (permalink / raw)
To: Andreas Mohr; +Cc: Erik Andren, linux-kernel, linux-pm
On Sun, Feb 14, 2010 at 04:47:10PM +0100, Andreas Mohr wrote:
> Definitely not only this one. E.g. my Inspiron 8000 (P3/700) has (dmidecode):
>
> Handle 0x0300, DMI type 3, 13 bytes
> Chassis Information
> Manufacturer: Dell Computer Corporation
> Type: Portable
>
> which, if "Portable" happens to be "8", means that it would match.
8 should be portable, yes. 9 would be laptop (and 10 notebook), but I
haven't seen any examples of those in Dells.
> So:
> - do all older matching machines grok this?
The dcdbas call should fail if they don't, so I think we're ok.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 10:54 [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist Erik Andren
2010-02-14 15:47 ` Andreas Mohr
2010-02-14 15:47 ` Andreas Mohr
@ 2010-02-14 16:55 ` Matthew Garrett
2010-02-14 18:59 ` Erik Andrén
2010-02-14 18:59 ` Erik Andrén
2010-02-14 16:55 ` Matthew Garrett
3 siblings, 2 replies; 14+ messages in thread
From: Matthew Garrett @ 2010-02-14 16:55 UTC (permalink / raw)
To: Erik Andren; +Cc: linux-kernel, linux-pm
On Sun, Feb 14, 2010 at 11:54:57AM +0100, Erik Andren wrote:
> The Latitude C640 has another variation of dell in its DMI vendor entry.
> Add it to the whitelist in order to enjoy the sweet fruits of software backlight toggling.
Thanks, picked up for .34.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 16:55 ` Matthew Garrett
@ 2010-02-14 18:59 ` Erik Andrén
2010-02-14 18:59 ` Erik Andrén
1 sibling, 0 replies; 14+ messages in thread
From: Erik Andrén @ 2010-02-14 18:59 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-pm, linux-kernel
2010/2/14 Matthew Garrett <mjg59@srcf.ucam.org>:
> On Sun, Feb 14, 2010 at 11:54:57AM +0100, Erik Andren wrote:
>> The Latitude C640 has another variation of dell in its DMI vendor entry.
>> Add it to the whitelist in order to enjoy the sweet fruits of software backlight toggling.
>
> Thanks, picked up for .34.
>
Darn, I forgot to add another module alias.
Shall I respin the whole patch or create another one depending on the old one?
Best regards,
Erik
> --
> Matthew Garrett | mjg59@srcf.ucam.org
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 16:55 ` Matthew Garrett
2010-02-14 18:59 ` Erik Andrén
@ 2010-02-14 18:59 ` Erik Andrén
2010-02-14 19:04 ` Matthew Garrett
2010-02-14 19:04 ` Matthew Garrett
1 sibling, 2 replies; 14+ messages in thread
From: Erik Andrén @ 2010-02-14 18:59 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-kernel, linux-pm
2010/2/14 Matthew Garrett <mjg59@srcf.ucam.org>:
> On Sun, Feb 14, 2010 at 11:54:57AM +0100, Erik Andren wrote:
>> The Latitude C640 has another variation of dell in its DMI vendor entry.
>> Add it to the whitelist in order to enjoy the sweet fruits of software backlight toggling.
>
> Thanks, picked up for .34.
>
Darn, I forgot to add another module alias.
Shall I respin the whole patch or create another one depending on the old one?
Best regards,
Erik
> --
> Matthew Garrett | mjg59@srcf.ucam.org
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 18:59 ` Erik Andrén
@ 2010-02-14 19:04 ` Matthew Garrett
2010-02-14 19:07 ` Erik Andrén
2010-02-14 19:07 ` Erik Andrén
2010-02-14 19:04 ` Matthew Garrett
1 sibling, 2 replies; 14+ messages in thread
From: Matthew Garrett @ 2010-02-14 19:04 UTC (permalink / raw)
To: Erik Andrén; +Cc: linux-kernel, linux-pm
On Sun, Feb 14, 2010 at 07:59:06PM +0100, Erik Andrén wrote:
> Darn, I forgot to add another module alias.
> Shall I respin the whole patch or create another one depending on the old one?
Oh, good point! I can add that myself and merge it in.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 19:04 ` Matthew Garrett
@ 2010-02-14 19:07 ` Erik Andrén
2010-02-14 19:07 ` Erik Andrén
1 sibling, 0 replies; 14+ messages in thread
From: Erik Andrén @ 2010-02-14 19:07 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-kernel, linux-pm
2010/2/14 Matthew Garrett <mjg59@srcf.ucam.org>:
> On Sun, Feb 14, 2010 at 07:59:06PM +0100, Erik Andrén wrote:
>
>> Darn, I forgot to add another module alias.
>> Shall I respin the whole patch or create another one depending on the old one?
>
> Oh, good point! I can add that myself and merge it in.
>
Thanks!
FWIW I've verified that the following string works:
MODULE_ALIAS("dmi:*svnDellComputerCorporation:*:ct8:*");
Best regards,
Erik
> --
> Matthew Garrett | mjg59@srcf.ucam.org
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 19:04 ` Matthew Garrett
2010-02-14 19:07 ` Erik Andrén
@ 2010-02-14 19:07 ` Erik Andrén
1 sibling, 0 replies; 14+ messages in thread
From: Erik Andrén @ 2010-02-14 19:07 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-pm, linux-kernel
2010/2/14 Matthew Garrett <mjg59@srcf.ucam.org>:
> On Sun, Feb 14, 2010 at 07:59:06PM +0100, Erik Andrén wrote:
>
>> Darn, I forgot to add another module alias.
>> Shall I respin the whole patch or create another one depending on the old one?
>
> Oh, good point! I can add that myself and merge it in.
>
Thanks!
FWIW I've verified that the following string works:
MODULE_ALIAS("dmi:*svnDellComputerCorporation:*:ct8:*");
Best regards,
Erik
> --
> Matthew Garrett | mjg59@srcf.ucam.org
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 18:59 ` Erik Andrén
2010-02-14 19:04 ` Matthew Garrett
@ 2010-02-14 19:04 ` Matthew Garrett
1 sibling, 0 replies; 14+ messages in thread
From: Matthew Garrett @ 2010-02-14 19:04 UTC (permalink / raw)
To: Erik Andrén; +Cc: linux-pm, linux-kernel
On Sun, Feb 14, 2010 at 07:59:06PM +0100, Erik Andrén wrote:
> Darn, I forgot to add another module alias.
> Shall I respin the whole patch or create another one depending on the old one?
Oh, good point! I can add that myself and merge it in.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
2010-02-14 10:54 [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist Erik Andren
` (2 preceding siblings ...)
2010-02-14 16:55 ` Matthew Garrett
@ 2010-02-14 16:55 ` Matthew Garrett
3 siblings, 0 replies; 14+ messages in thread
From: Matthew Garrett @ 2010-02-14 16:55 UTC (permalink / raw)
To: Erik Andren; +Cc: linux-pm, linux-kernel
On Sun, Feb 14, 2010 at 11:54:57AM +0100, Erik Andren wrote:
> The Latitude C640 has another variation of dell in its DMI vendor entry.
> Add it to the whitelist in order to enjoy the sweet fruits of software backlight toggling.
Thanks, picked up for .34.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist
@ 2010-02-14 10:54 Erik Andren
0 siblings, 0 replies; 14+ messages in thread
From: Erik Andren @ 2010-02-14 10:54 UTC (permalink / raw)
To: mjg; +Cc: linux-pm, linux-kernel, Erik Andren
The Latitude C640 has another variation of dell in its DMI vendor entry.
Add it to the whitelist in order to enjoy the sweet fruits of software backlight toggling.
Signed-off-by: Erik Andren <erik.andren@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 3780994..b5246f1 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -79,6 +79,13 @@ static const struct dmi_system_id __initdata dell_device_table[] = {
DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
},
},
+ {
+ .ident = "Dell Computer Corporation",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
+ },
+ },
{ }
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2010-02-14 19:07 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-14 10:54 [PATCH 1/1] platform/x86/dell-laptop: Add another Dell laptop to the DMI whitelist Erik Andren
2010-02-14 15:47 ` Andreas Mohr
2010-02-14 15:47 ` Andreas Mohr
2010-02-14 16:57 ` Matthew Garrett
2010-02-14 16:57 ` Matthew Garrett
2010-02-14 16:55 ` Matthew Garrett
2010-02-14 18:59 ` Erik Andrén
2010-02-14 18:59 ` Erik Andrén
2010-02-14 19:04 ` Matthew Garrett
2010-02-14 19:07 ` Erik Andrén
2010-02-14 19:07 ` Erik Andrén
2010-02-14 19:04 ` Matthew Garrett
2010-02-14 16:55 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2010-02-14 10:54 Erik Andren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.