Re: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.

Re: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.

[Denys Dmytriyenko]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

> Prevent a failure in do_populate_sdk when there are no empty
> directories:
>    /bin/rmdir: missing operand
>    Try `/bin/rmdir --help' for more information.
>
> See also http://tinderbox.openembedded.net/packages/478437/
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Acked-by: Denys Dmytriyenko <denis@denix.org>
> ---
>  recipes/meta/meta-toolchain.bb |      2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/meta/meta-toolchain.bb b/recipes/meta/meta-toolchain.bb
> index a8c27ec..3169425 100644
> --- a/recipes/meta/meta-toolchain.bb
> +++ b/recipes/meta/meta-toolchain.bb
> @@ -67,7 +67,7 @@ do_populate_sdk() {
>      rm -Rf ${SDK_OUTPUT}/usr/lib
> 
>      # Clean up empty directories from excluded packages
> -    find ${SDK_OUTPUT} -depth -type d -empty -print0 | xargs -0 /bin/rmdir
> +    find ${SDK_OUTPUT} -depth -type d -empty -print0 | xargs -r0 /bin/rmdir
> 
>      install -d ${SDK_OUTPUT}/${SDKPATH}/${TARGET_SYS}/${sysconfdir}
>      install -m 0644 ${IPKGCONF_TARGET} ${IPKGCONF_SDK}
> ${SDK_OUTPUT}/${SDKPATH}/${TARGET_SYS}/${sysconfdir}/
> --
> 1.6.6.2
>

Re: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.

[Stefan Schmidt]

Hello.

On Sat, 2010-02-13 at 20:34, Denys Dmytriyenko wrote:
> > Prevent a failure in do_populate_sdk when there are no empty
> > directories:
> >    /bin/rmdir: missing operand
> >    Try `/bin/rmdir --help' for more information.
> >
> > See also http://tinderbox.openembedded.net/packages/478437/
> >
> > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> Acked-by: Denys Dmytriyenko <denis@denix.org>

Acked and pushed. Now I need to find out how to update patchwork with the new
status...

regards
Stefan Schmidt

Update state in Patchwork. (was: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.)

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Dear Stefan,


Am Sonntag, den 14.02.2010, 14:09 +0100 schrieb Stefan Schmidt:
> On Sat, 2010-02-13 at 20:34, Denys Dmytriyenko wrote:
> > > Prevent a failure in do_populate_sdk when there are no empty
> > > directories:
> > >    /bin/rmdir: missing operand
> > >    Try `/bin/rmdir --help' for more information.
> > >
> > > See also http://tinderbox.openembedded.net/packages/478437/
> > >
> > > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> > Acked-by: Denys Dmytriyenko <denis@denix.org>
> 
> Acked and pushed. Now I need to find out how to update patchwork with the new
> status...

1. Register an account at [1].
2. Update the state.

a) Use the Web interface.
b) Use pwclient [2] and set it up with your account details and do the
following. 

    $ pwclient update -s applied -c <commit-ref> <ID>


Thanks,

Paul


[1] http://patchwork.openembedded.org/project/openembedded/list/
[2] http://patchwork.openembedded.org/project/openembedded/ (at the bottom)

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Update state in Patchwork. (was: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.)

[Stefan Schmidt]

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

Hello.

On Sun, 2010-02-14 at 16:50, Paul Menzel wrote:
> 
> Am Sonntag, den 14.02.2010, 14:09 +0100 schrieb Stefan Schmidt:
> > On Sat, 2010-02-13 at 20:34, Denys Dmytriyenko wrote:
> > > > Prevent a failure in do_populate_sdk when there are no empty
> > > > directories:
> > > >    /bin/rmdir: missing operand
> > > >    Try `/bin/rmdir --help' for more information.
> > > >
> > > > See also http://tinderbox.openembedded.net/packages/478437/
> > > >
> > > > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> > > Acked-by: Denys Dmytriyenko <denis@denix.org>
> > 
> > Acked and pushed. Now I need to find out how to update patchwork with the new
> > status...
> 
> 1. Register an account at [1].

Already done.

> 2. Update the state.

How? The webinterface does not offer my the functionality to change the state. I
guess it is because I'm not in the right group or have otherwise not enough
permissions in patchwork. As I just registered the account today it could be
that I'm to late in the game to get updated with the rights in the last batch.
:)

regards
Stefan Schmidt

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 258 bytes --]

Re: Update state in Patchwork. (was: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.)

[Michael Lippautz]

>> 2. Update the state.
>
> How? The webinterface does not offer my the functionality to change the state. I
> guess it is because I'm not in the right group or have otherwise not enough
> permissions in patchwork. As I just registered the account today it could be
> that I'm to late in the game to get updated with the rights in the last batch.
> :)
>
> regards
> Stefan Schmidt

I think you have to add the email address, the patch has been sent
from, to your account at [1].

(Atleast then I could update the status of MY patches that have been
rejected/applied by others.)

Regards,
Michael

[1] http://patchwork.openembedded.org/user/

Re: Update state in Patchwork. (was: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.)

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Am Sonntag, den 14.02.2010, 17:37 +0100 schrieb Michael Lippautz:
> >> 2. Update the state.
> >
> > How? The webinterface does not offer my the functionality to change the state. I
> > guess it is because I'm not in the right group or have otherwise not enough
> > permissions in patchwork. As I just registered the account today it could be
> > that I'm to late in the game to get updated with the rights in the last batch.
> > :)
>
> I think you have to add the email address, the patch has been sent
> from, to your account at [1].
> 
> (Atleast then I could update the status of MY patches that have been
> rejected/applied by others.)

I did not have do this as far as I can remember (there is just my own
address there). I just had to activate/confirm my account per email. Now
I have the options to change the state if I choose a patch from the list
[2].

Does it work with `pwclient` for you?


Thanks,

Paul


[2] http://patchwork.openembedded.org/project/openembedded/list/

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Update state in Patchwork. (was: [PATCH] meta-toolchain: Run rmdir only if empty dirs are actually found.)

[Denys Dmytriyenko]

On Sun, Feb 14, 2010 at 06:12:33PM +0100, Paul Menzel wrote:
> Am Sonntag, den 14.02.2010, 17:37 +0100 schrieb Michael Lippautz:
> > >> 2. Update the state.
> > >
> > > How? The webinterface does not offer my the functionality to change the state. I
> > > guess it is because I'm not in the right group or have otherwise not enough
> > > permissions in patchwork. As I just registered the account today it could be
> > > that I'm to late in the game to get updated with the rights in the last batch.
> > > :)
> >
> > I think you have to add the email address, the patch has been sent
> > from, to your account at [1].
> > 
> > (Atleast then I could update the status of MY patches that have been
> > rejected/applied by others.)
> 
> I did not have do this as far as I can remember (there is just my own
> address there). I just had to activate/confirm my account per email. Now
> I have the options to change the state if I choose a patch from the list
> [2].

Ask admins to enable proper permissions for your account and/or add you to the 
right group. Please don't add someone else's email addresses to your account.

-- 
Denys