From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Ian.Campbell@eu.citrix.com, jeremy@goop.org,
xen-devel@lists.xensource.com, chrisw@sous-sol.org,
iommu@lists.linux-foundation.org, dwmw2@infradead.org,
alex.williamson@hp.com
Subject: Re: Re: [RFC SWIOTLB-0.4]
Date: Tue, 16 Feb 2010 18:37:38 -0500 [thread overview]
Message-ID: <20100216233738.GA16710@phenom.dumpdata.com> (raw)
In-Reply-To: <20100204030749.GB15580@phenom.dumpdata.com>
On Wed, Feb 03, 2010 at 10:07:49PM -0500, Konrad Rzeszutek Wilk wrote:
> On Thu, Feb 04, 2010 at 09:17:31AM +0900, FUJITA Tomonori wrote:
> > On Wed, 3 Feb 2010 12:08:01 -0500
> > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> >
> > > Attached is a set of eleven RFC patches that split the SWIOTLB library in
> > > two layers: core, and dma_ops related functions.
> >
> > What's the point of splitting swiotlb.c? Why can't you just export
> > some of functions in swiotlb.c?
>
> I was emulating some of the other libraries that are in the kernel,
> where the core functionality was in -core.c file and the users of it
> are in subsequent once (libata).
Thought there is one thing Jens Axboe mentioned that I didn't think off:
Keep it as simple and as few.
I've redone the patches, this time without the splitting and have
exported the symbols.
The git tree is:
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb-2.6.git swiotlb-0.5
And the LKML posting is:
https://lists.linux-foundation.org/pipermail/iommu/2010-February/002066.html
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2010-02-16 23:37 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 23:00 [RFC SWIOTLB-0.2] Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 01/15] [swiotlb] fix: Update 'setup_io_tlb_npages' to accept both arguments in either order Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 02/15] [swiotlb] Add swiotlb_engine structure for tracking multiple software IO TLBs Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 03/15] [swiotlb] Add swiotlb_register_engine function Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 04/15] [swiotlb] Search and replace s/io_tlb/iommu_sw->/ Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 05/15] [swiotlb] Respect the io_tlb_nslabs argument value Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 06/15] [swiotlb] In 'swiotlb_init' take advantage of the default swiotlb_engine support Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw pointer Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 08/15] [swiotlb] Add 'is_swiotlb_buffer' to the swiotlb_ops function decleration Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 09/15] [swiotlb] Add 'dma_capable' to the swiotlb_ops structure Konrad Rzeszutek Wilk
2010-01-14 23:00 ` [PATCH 10/15] [swiotlb] Replace the [phys, bus]->virt and virt->[bus, phys] functions with iommu_sw calls Konrad Rzeszutek Wilk
2010-01-14 23:01 ` [PATCH 11/15] [swiotlb] Replace late_alloc with iommu_sw->priv usage Konrad Rzeszutek Wilk
2010-01-14 23:01 ` [PATCH 12/15] [swiotlb] Remove un-used static declerations obsoleted by iommu_sw Konrad Rzeszutek Wilk
2010-01-14 23:01 ` [PATCH 13/15] [swiotlb] Make io_tlb_nslabs visible outside lib/swiotlb.c and rename it Konrad Rzeszutek Wilk
2010-01-14 23:01 ` [PATCH 14/15] [swiotlb] Move initialization (swiotlb_init) and its friends in swiotlb-default.c Konrad Rzeszutek Wilk
2010-01-14 23:01 ` [PATCH 15/15] [swiotlb] Take advantage of iommu_sw->name and add %s to printk's Konrad Rzeszutek Wilk
2010-01-15 2:14 ` [PATCH 14/15] [swiotlb] Move initialization (swiotlb_init) and its friends in swiotlb-default.c Chris Wright
2010-01-19 17:45 ` Konrad Rzeszutek Wilk
2010-01-19 18:55 ` Chris Wright
2010-01-15 2:02 ` [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw pointer Chris Wright
2010-01-19 17:45 ` Konrad Rzeszutek Wilk
2010-01-19 18:23 ` Chris Wright
2010-01-15 1:57 ` [PATCH 06/15] [swiotlb] In 'swiotlb_init' take advantage of the default swiotlb_engine support Chris Wright
2010-01-19 17:45 ` Konrad Rzeszutek Wilk
2010-01-15 1:47 ` [PATCH 05/15] [swiotlb] Respect the io_tlb_nslabs argument value Chris Wright
2010-01-15 1:43 ` [PATCH 04/15] [swiotlb] Search and replace s/io_tlb/iommu_sw->/ Chris Wright
2010-01-19 17:45 ` Konrad Rzeszutek Wilk
2010-01-15 1:41 ` [PATCH 03/15] [swiotlb] Add swiotlb_register_engine function Chris Wright
2010-01-19 17:25 ` Konrad Rzeszutek Wilk
2010-01-15 1:33 ` [PATCH 02/15] [swiotlb] Add swiotlb_engine structure for tracking multiple software IO TLBs Chris Wright
2010-01-19 17:46 ` Konrad Rzeszutek Wilk
2010-01-19 18:43 ` Chris Wright
2010-01-22 1:51 ` FUJITA Tomonori
2010-01-26 16:20 ` Konrad Rzeszutek Wilk
2010-02-03 2:04 ` FUJITA Tomonori
2010-02-03 17:08 ` [RFC SWIOTLB-0.4] Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 01/11] [swiotlb] fix: Update 'setup_io_tlb_npages' to accept both arguments in either order Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 02/11] [swiotlb] Make 'setup_io_tlb_npages' accept new 'swiotlb=' syntax Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 03/11] [swiotlb] Normalize the swiotlb_init_* function's naming syntax Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 04/11] [swiotlb] Make printk's use same prefix and include dev_err when possible Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 05/11] [swiotlb] Make internal bookkeeping functions have 'do_' prefix Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 06/11] [swiotlb] do_map_single: abstract out swiotlb_virt_to_bus calls out Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 07/11] [swiotlb] Fix checkpatch warnings Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 08/11] [swiotlb] Re-order the function declerations Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 09/11] [swiotlb] Make swiotlb bookkeeping functions visible in the header file Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 10/11] [swiotlb] Rename swiotlb.c to swiotlb-core.c Konrad Rzeszutek Wilk
2010-02-03 17:08 ` [PATCH 11/11] [swiotlb] move dma_ops functions to swiotlb.c Konrad Rzeszutek Wilk
2010-02-04 0:17 ` [RFC SWIOTLB-0.4] FUJITA Tomonori
2010-02-04 3:07 ` Konrad Rzeszutek Wilk
2010-02-16 23:37 ` Konrad Rzeszutek Wilk [this message]
2010-01-15 1:22 ` [PATCH 01/15] [swiotlb] fix: Update 'setup_io_tlb_npages' to accept both arguments in either order Chris Wright
2010-01-19 17:47 ` Konrad Rzeszutek Wilk
2010-01-19 19:00 ` Chris Wright
2010-01-19 19:39 ` Konrad Rzeszutek Wilk
2010-01-15 2:25 ` [RFC SWIOTLB-0.2] Chris Wright
2010-01-19 18:20 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216233738.GA16710@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=alex.williamson@hp.com \
--cc=chrisw@sous-sol.org \
--cc=dwmw2@infradead.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.