[PATCH 01/05] tmio_mmc: Keep card-detect interrupts enabled

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Magnus Damm <magnus.damm@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: sameo@linux.intel.com, linux-sh@vger.kernel.org,
	linus.ml.walleij@gmail.com, akpm@linux-foundation.org,
	goda.yusuke@renesas.com, ian@mnementh.co.uk, lethal@linux-sh.org,
	Magnus Damm <magnus.damm@gmail.com>,
	g.liakhovetski@gmx.de
Subject: [PATCH 01/05] tmio_mmc: Keep card-detect interrupts enabled
Date: Wed, 17 Feb 2010 16:37:45 +0900	[thread overview]
Message-ID: <20100217073745.32726.24254.sendpatchset@t400s> (raw)
In-Reply-To: <20100217073735.32726.12020.sendpatchset@t400s>

From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

On SuperH platforms the SDHI controller does not produce any command IRQs after
a completed IO. This leads to card-detect interrupts staying disabled. Do not
disable card-detect interrupts on DATA IRQs.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Previously posted by Guennadi to linux-mmc 20100216 as
 "[PATCH] tmio_mmc: keep card-detect interrupts enabled"

 drivers/mmc/host/tmio_mmc.h |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index 692dc23..dafecfb 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -55,10 +55,8 @@
 /* Define some IRQ masks */
 /* This is the mask used at reset by the chip */
 #define TMIO_MASK_ALL           0x837f031d
-#define TMIO_MASK_READOP  (TMIO_STAT_RXRDY | TMIO_STAT_DATAEND | \
-		TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT)
-#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND | \
-		TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT)
+#define TMIO_MASK_READOP  (TMIO_STAT_RXRDY | TMIO_STAT_DATAEND)
+#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND)
 #define TMIO_MASK_CMD     (TMIO_STAT_CMDRESPEND | TMIO_STAT_CMDTIMEOUT | \
 		TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT)
 #define TMIO_MASK_IRQ     (TMIO_MASK_READOP | TMIO_MASK_WRITEOP | TMIO_MASK_CMD)
-- 
1.6.2.4

--

WARNING: multiple messages have this Message-ID (diff)

From: Magnus Damm <magnus.damm@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: sameo@linux.intel.com, linux-sh@vger.kernel.org,
	linus.ml.walleij@gmail.com, akpm@linux-foundation.org,
	goda.yusuke@renesas.com, ian@mnementh.co.uk, lethal@linux-sh.org,
	Magnus Damm <magnus.damm@gmail.com>,
	g.liakhovetski@gmx.de
Subject: [PATCH 01/05] tmio_mmc: Keep card-detect interrupts enabled
Date: Wed, 17 Feb 2010 07:37:45 +0000	[thread overview]
Message-ID: <20100217073745.32726.24254.sendpatchset@t400s> (raw)
In-Reply-To: <20100217073735.32726.12020.sendpatchset@t400s>

From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

On SuperH platforms the SDHI controller does not produce any command IRQs after
a completed IO. This leads to card-detect interrupts staying disabled. Do not
disable card-detect interrupts on DATA IRQs.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Previously posted by Guennadi to linux-mmc 20100216 as
 "[PATCH] tmio_mmc: keep card-detect interrupts enabled"

 drivers/mmc/host/tmio_mmc.h |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index 692dc23..dafecfb 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -55,10 +55,8 @@
 /* Define some IRQ masks */
 /* This is the mask used at reset by the chip */
 #define TMIO_MASK_ALL           0x837f031d
-#define TMIO_MASK_READOP  (TMIO_STAT_RXRDY | TMIO_STAT_DATAEND | \
-		TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT)
-#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND | \
-		TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT)
+#define TMIO_MASK_READOP  (TMIO_STAT_RXRDY | TMIO_STAT_DATAEND)
+#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND)
 #define TMIO_MASK_CMD     (TMIO_STAT_CMDRESPEND | TMIO_STAT_CMDTIMEOUT | \
 		TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT)
 #define TMIO_MASK_IRQ     (TMIO_MASK_READOP | TMIO_MASK_WRITEOP | TMIO_MASK_CMD)
-- 
1.6.2.4

--

next prev parent reply	other threads:[~2010-02-17  7:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17  7:37 [PATCH 00/05] tmio_mmc: SDHI hotplug and random fixes Magnus Damm
2010-02-17  7:37 ` Magnus Damm
2010-02-17  7:37 ` Magnus Damm [this message]
2010-02-17  7:37   ` [PATCH 01/05] tmio_mmc: Keep card-detect interrupts enabled Magnus Damm
2010-02-17  7:37 ` [PATCH 02/05] tmio_mmc: Add MMC_CAP_MMC_HIGHSPEED support V2 Magnus Damm
2010-02-17  7:37   ` Magnus Damm
2010-02-17  7:38 ` [PATCH 03/05] tmio_mmc: Use 100ms mmc_detect_change() delay Magnus Damm
2010-02-17  7:38   ` Magnus Damm
2010-02-17  7:38 ` [PATCH 04/05] tmio_mmc: Remove const from platform data V3 Magnus Damm
2010-02-17  7:38   ` Magnus Damm
2010-02-17  7:38 ` [PATCH 05/05] tmio_mmc: Balance cell enable()/disable() calls Magnus Damm
2010-02-17  7:38   ` Magnus Damm
2010-02-19 11:46 ` [PATCH 00/05] tmio_mmc: SDHI hotplug and random fixes Samuel Ortiz
2010-02-19 11:46   ` Samuel Ortiz
2010-02-22  4:43   ` Magnus Damm
2010-02-22  4:43     ` Magnus Damm
2010-02-28 19:03     ` Samuel Ortiz
2010-02-28 19:03       ` Samuel Ortiz

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:692dc23 dfblob:dafecfb dfblob:692dc23 dfblob:dafecfb )
 OR (
bs:"[PATCH 01/05] tmio_mmc: Keep card-detect interrupts enabled" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217073745.32726.24254.sendpatchset@t400s \
    --to=magnus.damm@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=goda.yusuke@renesas.com \
    --cc=ian@mnementh.co.uk \
    --cc=lethal@linux-sh.org \
    --cc=linus.ml.walleij@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.