Re: [RFC][PATCH v2] serial: spi: add spi-uart driver for Maxim 3110

[Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

On Tue, Feb 09, 2010 at 09:36:44AM +0800, Feng Tang wrote:
> On Tue, 9 Feb 2010 08:26:35 +0800
> Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> 
> > On Mon, Feb 8, 2010 at 5:20 PM, Andrew Morton
> > <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> > > On Mon, 8 Feb 2010 16:59:46 +0800
> > > Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > >> Hi All,
> > >>
> > >> Here is a driver for Maxim 3110 SPI-UART device, please help to
> > >> review.
> > >>
> > >> It has been validated with Designware SPI controller (drivers/spi:
> > >> dw_spi.c & dw_spi_pci.c). It supports polling and IRQ mode,
> > >> supports batch read, and provides a console.
> > >>
> 
> > > I wonder if this is an "spi" subsystem thing or a "serial" subsystem
> > > thing.  It looks more like a serial driver to me.
> > 
> > I'm assuming serial; and hence I haven't picked it up into my tree.
> > 
> > g.
> 
> Yes, it's more related to serial stuff, and thus I put them into
> drivers/serial

That's fine.  Care to address Andrew's issues and resend the patch?

thanks,

greg k-h

------------------------------------------------------------------------------
Download Intel&reg; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs 
proactively, and fine-tune applications for parallel performance. 
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev