From: Feng Tang <feng.tang@intel.com>
To: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Cc: Greg KH <greg@kroah.com>,
David Brownell <dbrownell@users.sourceforge.net>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
spi-devel-list <spi-devel-general@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH v4] serial: spi: add spi-uart driver for Maxim 3110
Date: Tue, 2 Mar 2010 11:38:17 +0800 [thread overview]
Message-ID: <20100302113817.155f78aa@feng-i7> (raw)
In-Reply-To: <201002260959.o1Q9xIVA021953@imail.sm.sony.co.jp>
On Fri, 26 Feb 2010 17:59:38 +0800
Masakazu Mokuno <mokuno@sm.sony.co.jp> wrote:
> Hi,
>
> > + u8 *pbuf, valid_str[M3110_RX_FIFO_DEPTH];
> > + int i, j;
> > +
> > + memset(obuf, 0, sizeof(obuf));
> > + memset(obuf, 0, sizeof(ibuf));
>
> memset(ibuf, 0, sizeof(ibuf))?
thanks for the catch, here is a follow on patch
diff --git a/drivers/serial/max3110.c b/drivers/serial/max3110.c
index 3283ba6..3dd2082 100644
--- a/drivers/serial/max3110.c
+++ b/drivers/serial/max3110.c
@@ -142,7 +142,7 @@ static int max3110_read_multi(struct uart_max3110 *max, u8 *buf)
int i, j;
memset(obuf, 0, sizeof(obuf));
- memset(obuf, 0, sizeof(ibuf));
+ memset(ibuf, 0, sizeof(ibuf));
if (max3110_write_then_read(max, obuf, ibuf,
M3110_RX_FIFO_DEPTH * 2, 1))
next prev parent reply other threads:[~2010-03-02 3:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 14:20 [RFC][PATCH] serial: spi: add spi-uart driver for Maxim 3110 Feng Tang
2009-12-29 14:59 ` [spi-devel-general] " Baruch Siach
2009-12-29 16:05 ` Tang, Feng
2009-12-29 18:43 ` Erwin Authried
2009-12-30 1:54 ` Feng Tang
2010-02-25 4:47 ` David Brownell
2010-02-25 7:49 ` Feng Tang
2009-12-29 15:02 ` Alan Cox
2010-02-08 8:59 ` [RFC][PATCH v2] " Feng Tang
2010-02-08 8:59 ` Feng Tang
2010-02-09 0:20 ` Andrew Morton
2010-02-09 0:26 ` Grant Likely
2010-02-09 1:36 ` Feng Tang
2010-02-17 22:58 ` Greg KH
2010-02-24 5:11 ` [RFC][PATCH v3] " Feng Tang
2010-02-24 10:44 ` Alan Cox
2010-02-24 14:25 ` Grant Likely
2010-02-24 23:18 ` Andrew Morton
2010-02-25 6:39 ` Feng Tang
2010-02-25 4:43 ` David Brownell
2010-02-25 7:44 ` Feng Tang
2010-02-25 8:11 ` David Brownell
2010-02-26 3:47 ` [PATCH v4] " Feng Tang
2010-02-26 3:47 ` Feng Tang
2010-02-26 9:59 ` Masakazu Mokuno
2010-02-26 19:41 ` David Brownell
2010-03-01 2:30 ` Feng Tang
2010-03-02 3:38 ` Feng Tang [this message]
2010-02-09 9:25 ` [RFC][PATCH v2] " Alan Cox
2010-03-03 2:57 ` [PATCH v5] " Feng Tang
2010-03-03 3:59 ` Grant Likely
2010-03-03 4:51 ` David Brownell
2010-03-03 5:52 ` Feng Tang
2010-03-03 6:16 ` David Brownell
2010-03-03 6:37 ` Feng Tang
2010-03-03 7:25 ` David Brownell
2010-03-03 7:42 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302113817.155f78aa@feng-i7 \
--to=feng.tang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=linux-serial@vger.kernel.org \
--cc=mokuno@sm.sony.co.jp \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.