* Re: [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
@ 2008-12-14 17:25 ` Franky Van Liedekerke
2010-01-26 15:17 ` Gerd v. Egidy
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Franky Van Liedekerke @ 2008-12-14 17:25 UTC (permalink / raw)
To: mlmmj
On Sun, 14 Dec 2008 01:23:12 +0100
"Gerd v. Egidy" <lists@egidy.de> wrote:
> Hi,
>
> I've been bitten by the footer-function not being MIME-aware. I've
> read up the topic on the list-archive and found out that I'm not the
> only one and that a solution has to be separatable from the core
> mlmmj.
>
> I found the altermime program (http://www.pldaniels.com/altermime/)
> which seems to be a perfect match for the MIME-munging required. So I
> wrote a small shell script to integrate altermime and mlmmj.
>
> How to use it:
>
> - install altermime to /usr/bin/altermime
> - copy the attached mlmmj-amime-receive into /usr/bin
> - put the footer-text for the different MIME-types into
> control/amime-footer-text
> control/amime-footer-html
> control/amime-footer-base64
> - replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
> myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
> watch out for recieve vs. receive...
> - newaliases
>
> Morten, I hope this solution is acceptable for inclusion into mlmmj.
> I attached mlmmj-amime.patch too, this is intended for you and adds
> mlmmj-amime- receive into contrib.
>
> Kind regards,
>
> Gerd
>
Nice! This seems totally non-intrusive and changes nothing for existing
users, so I vote for this inclusion into contrib (together with a
readme). A small remark: since the paths for /usr/bin/altermime and
mlmmj-amime-receive can be different than the ones mentioned above, you
should probably say :
"- install altermime to /usr/bin/altermime or change the path in the
file contrib/mlmmj-amime-receive"
"- check the path of mlmmj-recieve at the top of the file
contrib/mlmmj-amime-receive"
(since the shell script already has these as parameters, you might as
well advertise it :-) )
Franky
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
2008-12-14 17:25 ` Franky Van Liedekerke
@ 2010-01-26 15:17 ` Gerd v. Egidy
2010-02-18 15:30 ` Gerd v. Egidy
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gerd v. Egidy @ 2010-01-26 15:17 UTC (permalink / raw)
To: mlmmj
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
Hi,
this patch has already been sent in dec 2008 to this ml but was not yet
applied. I guess it was forgotten.
The patch allows adding footers to different MIME-types. It uses altermime to
add the footers before giving the mail to the regular mlmmj-functions. Mlmmj
itself doesn't need to be changed to use this.
How to use it:
- install altermime to /usr/bin/altermime
- copy the mlmmj-amime-receive from the contrib-dir into /usr/bin
- put the footer-text for the different MIME-types into
control/amime-footer-text
control/amime-footer-html
control/amime-footer-base64
- replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
watch out for recieve vs. receive...
- newaliases
If this patch is not acceptable in its current form or missing something
please speak up.
Kind regards,
Gerd
--
Address (better: trap) for people I really don't want to get mail from:
jonas@cactusamerica.com
[-- Attachment #2: mlmmj-amime.patch --]
[-- Type: text/x-patch, Size: 2930 bytes --]
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/Makefile.am mlmmj-1.2.16-RC1/contrib/Makefile.am
--- mlmmj-1.2.16-RC1.orig/contrib/Makefile.am 2008-10-30 21:06:16.000000000 +0100
+++ mlmmj-1.2.16-RC1/contrib/Makefile.am 2008-12-13 23:39:33.000000000 +0100
@@ -2,3 +2,5 @@
EXTRA_DIST = web
SUBDIRS = recievestrip
+
+bin_SCRIPTS = mlmmj-amime-receive
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/mlmmj-amime-receive mlmmj-1.2.16-RC1/contrib/mlmmj-amime-receive
--- mlmmj-1.2.16-RC1.orig/contrib/mlmmj-amime-receive 1970-01-01 01:00:00.000000000 +0100
+++ mlmmj-1.2.16-RC1/contrib/mlmmj-amime-receive 2008-12-13 23:23:23.000000000 +0100
@@ -0,0 +1,89 @@
+#!/bin/bash
+#
+# mlmmj-amime-receive
+#
+# Take mail from stdin, pipe it through altermime and then to mlmmj-recieve
+# needed to add footers in a MIME-aware way
+#
+# requires altermime, see http://www.pldaniels.com/altermime/
+#
+# just replace mlmmj-recieve (sic) with mlmmj-amime-receive, e.g. in /etc/aliases:
+# myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
+#
+# put the footer-text for the different MIME-types into
+# control/amime-footer-text
+# control/amime-footer-html
+# control/amime-footer-base64
+#
+# Copyright 2008 by Gerd v. Egidy, <gerd@egidy.de>
+#
+# Licensed under MIT License, see LICENSE file coming with mlmmj
+#
+
+MLMMJRECIEVE=/usr/bin/mlmmj-recieve
+ALTERMIME=/usr/bin/altermime
+
+# check executables
+if ! [ -x $MLMMJRECIEVE ]; then
+ echo "can't find $MLMMJRECIEVE executable, aborting"
+ exit 1
+fi
+
+if ! [ -x $ALTERMIME ]; then
+ echo "can't find $ALTERMIME executable, aborting"
+ exit 1
+fi
+
+# read parameters
+I=1
+PARAM_L=0
+while [ $I -le $# ] && [ $PARAM_L == 0 ]; do
+ if [ "${!I}" == "-L" ]; then
+ PARAM_L=1
+ fi
+ I=$[$I+1]
+done
+
+if [ $PARAM_L == 1 ] && [ $I -le $# ]; then
+ MLPATH="${!I}"
+else
+ echo "parameter -L /path/to/listdir missing, aborting"
+ exit 1
+fi
+
+if ! [ -d "${MLPATH}" ]; then
+ echo "${MLPATH} is not existing or no directory, aborting"
+ exit 1
+fi
+
+CONTROLD="${MLPATH}/control"
+
+if ! [ -d "${CONTROLD}" ]; then
+ echo "${CONTROLD} is not existing or no directory, aborting"
+ exit 1
+fi
+
+# look for footer-files and build parameters
+
+if ! [ -f "${CONTROLD}/amime-footer-text" ]; then
+ echo "${CONTROLD}/amime-footer-text is not existing or no regular file, aborting"
+ exit 1
+fi
+
+PARAM="--disclaimer=${CONTROLD}/amime-footer-text"
+
+if [ -f "${CONTROLD}/amime-footer-html" ]; then
+ PARAM="${PARAM} --disclaimer-html=${CONTROLD}/amime-footer-html --htmltoo --force-for-bad-html"
+fi
+
+if [ -f "${CONTROLD}/amime-footer-base64" ]; then
+ PARAM="${PARAM} --disclaimer-b64=${CONTROLD}/amime-footer-base64"
+fi
+
+PARAM="${PARAM} --altersigned --log-syslog"
+
+# go to a dir where altermime can write it's tmp-files safely
+cd $MLPATH
+
+# pipe the calls
+$ALTERMIME --input=- ${PARAM} | $MLMMJRECIEVE "$@"
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
2008-12-14 17:25 ` Franky Van Liedekerke
2010-01-26 15:17 ` Gerd v. Egidy
@ 2010-02-18 15:30 ` Gerd v. Egidy
2010-02-18 16:25 ` Morten Shearman Kirkegaard
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gerd v. Egidy @ 2010-02-18 15:30 UTC (permalink / raw)
To: mlmmj
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
Hi Morten,
this patch has already been sent in dec 2008 and jan 2010 to this ml but was
not yet applied. I guess it was forgotten. You said something about pestering
you until you commited it. So here I am...
The patch allows adding footers to different MIME-types. It uses altermime to
add the footers before giving the mail to the regular mlmmj-functions. Mlmmj
itself doesn't need to be changed to use this.
How to use it:
- install altermime to /usr/bin/altermime
- copy the mlmmj-amime-receive from the contrib-dir into /usr/bin
- put the footer-text for the different MIME-types into
control/amime-footer-text
control/amime-footer-html
control/amime-footer-base64
- replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
watch out for recieve vs. receive...
- newaliases
If this patch is not acceptable in its current form or missing something
please speak up.
Kind regards,
Gerd
--
Address (better: trap) for people I really don't want to get mail from:
jonas@cactusamerica.com
[-- Attachment #2: mlmmj-amime.patch --]
[-- Type: text/x-patch, Size: 2930 bytes --]
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/Makefile.am mlmmj-1.2.16-RC1/contrib/Makefile.am
--- mlmmj-1.2.16-RC1.orig/contrib/Makefile.am 2008-10-30 21:06:16.000000000 +0100
+++ mlmmj-1.2.16-RC1/contrib/Makefile.am 2008-12-13 23:39:33.000000000 +0100
@@ -2,3 +2,5 @@
EXTRA_DIST = web
SUBDIRS = recievestrip
+
+bin_SCRIPTS = mlmmj-amime-receive
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/mlmmj-amime-receive mlmmj-1.2.16-RC1/contrib/mlmmj-amime-receive
--- mlmmj-1.2.16-RC1.orig/contrib/mlmmj-amime-receive 1970-01-01 01:00:00.000000000 +0100
+++ mlmmj-1.2.16-RC1/contrib/mlmmj-amime-receive 2008-12-13 23:23:23.000000000 +0100
@@ -0,0 +1,89 @@
+#!/bin/bash
+#
+# mlmmj-amime-receive
+#
+# Take mail from stdin, pipe it through altermime and then to mlmmj-recieve
+# needed to add footers in a MIME-aware way
+#
+# requires altermime, see http://www.pldaniels.com/altermime/
+#
+# just replace mlmmj-recieve (sic) with mlmmj-amime-receive, e.g. in /etc/aliases:
+# myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
+#
+# put the footer-text for the different MIME-types into
+# control/amime-footer-text
+# control/amime-footer-html
+# control/amime-footer-base64
+#
+# Copyright 2008 by Gerd v. Egidy, <gerd@egidy.de>
+#
+# Licensed under MIT License, see LICENSE file coming with mlmmj
+#
+
+MLMMJRECIEVE=/usr/bin/mlmmj-recieve
+ALTERMIME=/usr/bin/altermime
+
+# check executables
+if ! [ -x $MLMMJRECIEVE ]; then
+ echo "can't find $MLMMJRECIEVE executable, aborting"
+ exit 1
+fi
+
+if ! [ -x $ALTERMIME ]; then
+ echo "can't find $ALTERMIME executable, aborting"
+ exit 1
+fi
+
+# read parameters
+I=1
+PARAM_L=0
+while [ $I -le $# ] && [ $PARAM_L == 0 ]; do
+ if [ "${!I}" == "-L" ]; then
+ PARAM_L=1
+ fi
+ I=$[$I+1]
+done
+
+if [ $PARAM_L == 1 ] && [ $I -le $# ]; then
+ MLPATH="${!I}"
+else
+ echo "parameter -L /path/to/listdir missing, aborting"
+ exit 1
+fi
+
+if ! [ -d "${MLPATH}" ]; then
+ echo "${MLPATH} is not existing or no directory, aborting"
+ exit 1
+fi
+
+CONTROLD="${MLPATH}/control"
+
+if ! [ -d "${CONTROLD}" ]; then
+ echo "${CONTROLD} is not existing or no directory, aborting"
+ exit 1
+fi
+
+# look for footer-files and build parameters
+
+if ! [ -f "${CONTROLD}/amime-footer-text" ]; then
+ echo "${CONTROLD}/amime-footer-text is not existing or no regular file, aborting"
+ exit 1
+fi
+
+PARAM="--disclaimer=${CONTROLD}/amime-footer-text"
+
+if [ -f "${CONTROLD}/amime-footer-html" ]; then
+ PARAM="${PARAM} --disclaimer-html=${CONTROLD}/amime-footer-html --htmltoo --force-for-bad-html"
+fi
+
+if [ -f "${CONTROLD}/amime-footer-base64" ]; then
+ PARAM="${PARAM} --disclaimer-b64=${CONTROLD}/amime-footer-base64"
+fi
+
+PARAM="${PARAM} --altersigned --log-syslog"
+
+# go to a dir where altermime can write it's tmp-files safely
+cd $MLPATH
+
+# pipe the calls
+$ALTERMIME --input=- ${PARAM} | $MLMMJRECIEVE "$@"
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
` (2 preceding siblings ...)
2010-02-18 15:30 ` Gerd v. Egidy
@ 2010-02-18 16:25 ` Morten Shearman Kirkegaard
2010-02-18 17:01 ` Gerd v. Egidy
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Morten Shearman Kirkegaard @ 2010-02-18 16:25 UTC (permalink / raw)
To: mlmmj
Hi Gerd,
On Thu, 2010-02-18 at 16:30 +0100, Gerd v. Egidy wrote:
> this patch has already been sent in dec 2008 and jan 2010 to this ml but was
> not yet applied. I guess it was forgotten.
Not forgotten, but I am still working my way through January's mail.
> You said something about pestering you until you commited it. So here I
> am...
I really appreciate your patience with me.
> The patch allows adding footers to different MIME-types. It uses altermime to
> add the footers before giving the mail to the regular mlmmj-functions. Mlmmj
> itself doesn't need to be changed to use this.
Thanks a lot. I've committed it to CVS now, and it will be included in
the next release.
Morten
--
Morten Shearman Kirkegaard <moki@fabletech.com>
CTO, FableTech
http://fabletech.com/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
` (3 preceding siblings ...)
2010-02-18 16:25 ` Morten Shearman Kirkegaard
@ 2010-02-18 17:01 ` Gerd v. Egidy
2010-02-18 17:22 ` Morten Shearman Kirkegaard
2010-02-18 17:54 ` Mads Martin Jørgensen
6 siblings, 0 replies; 8+ messages in thread
From: Gerd v. Egidy @ 2010-02-18 17:01 UTC (permalink / raw)
To: mlmmj
Hi Morten,
> > You said something about pestering you until you commited it. So here I
> > am...
>
> I really appreciate your patience with me.
no worries, I know how it is to maintain an open source project and often lag
in responding too.
> > The patch allows adding footers to different MIME-types. It uses
> > altermime to add the footers before giving the mail to the regular
> > mlmmj-functions. Mlmmj itself doesn't need to be changed to use this.
>
> Thanks a lot. I've committed it to CVS now, and it will be included in
> the next release.
Thank you.
BTW, is the CVS available to the public somewhere?
Kind regards,
Gerd
--
Address (better: trap) for people I really don't want to get mail from:
jonas@cactusamerica.com
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
` (4 preceding siblings ...)
2010-02-18 17:01 ` Gerd v. Egidy
@ 2010-02-18 17:22 ` Morten Shearman Kirkegaard
2010-02-18 17:54 ` Mads Martin Jørgensen
6 siblings, 0 replies; 8+ messages in thread
From: Morten Shearman Kirkegaard @ 2010-02-18 17:22 UTC (permalink / raw)
To: mlmmj
On Thu, 2010-02-18 at 18:01 +0100, Gerd v. Egidy wrote:
> BTW, is the CVS available to the public somewhere?
Not at the moment, but if you drop Mads Martin a mail, you might be able
to convince him to create an account for you.
Morten
--
Morten Shearman Kirkegaard <moki@fabletech.com>
CTO, FableTech
http://fabletech.com/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] add MIME-aware footers
2008-12-14 0:23 [PATCH] add MIME-aware footers Gerd v. Egidy
` (5 preceding siblings ...)
2010-02-18 17:22 ` Morten Shearman Kirkegaard
@ 2010-02-18 17:54 ` Mads Martin Jørgensen
6 siblings, 0 replies; 8+ messages in thread
From: Mads Martin Jørgensen @ 2010-02-18 17:54 UTC (permalink / raw)
To: mlmmj
On 18/02/2010, at 18.22, Morten Shearman Kirkegaard wrote:
>> BTW, is the CVS available to the public somewhere?
>
> Not at the moment, but if you drop Mads Martin a mail, you might be able
> to convince him to create an account for you.
I would much rather someone converted it to something and put it somewhere :)
--
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
and totally illogical, with just a little bit more effort?"
-- A. P. J.
^ permalink raw reply [flat|nested] 8+ messages in thread