From: Stephen Hemminger <shemminger@vyatta.com>
To: Vlad Yasevich <vladislav.yasevich@hp.com>,
Sridhar Samudrala <sri@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: [RFC 2/2] SCTP: fix sparse warning
Date: Fri, 19 Feb 2010 05:55:22 +0000 [thread overview]
Message-ID: <20100219055628.517807379@vyatta.com> (raw)
In-Reply-To: 20100219055520.223027612@vyatta.com
The variable node shadows earlier one in same function.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/sctp/socket.c 2010-02-18 10:06:57.656887238 -0800
+++ b/net/sctp/socket.c 2010-02-18 10:07:09.894132363 -0800
@@ -5478,7 +5478,7 @@ pp_found:
*/
int reuse = sk->sk_reuse;
struct sock *sk2;
- struct hlist_node *node;
+ struct hlist_node *node2;
SCTP_DEBUG_PRINTK("sctp_get_port() found a possible match\n");
if (pp->fastreuse && sk->sk_reuse &&
@@ -5495,7 +5495,7 @@ pp_found:
* that this port/socket (sk) combination are already
* in an endpoint.
*/
- sk_for_each_bound(sk2, node, &pp->owner) {
+ sk_for_each_bound(sk2, node2, &pp->owner) {
struct sctp_endpoint *ep2;
ep2 = sctp_sk(sk2)->ep;
--
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: Vlad Yasevich <vladislav.yasevich@hp.com>,
Sridhar Samudrala <sri@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: [RFC 2/2] SCTP: fix sparse warning
Date: Thu, 18 Feb 2010 21:55:22 -0800 [thread overview]
Message-ID: <20100219055628.517807379@vyatta.com> (raw)
In-Reply-To: 20100219055520.223027612@vyatta.com
[-- Attachment #1: sctp-sparse.patch --]
[-- Type: text/plain, Size: 767 bytes --]
The variable node shadows earlier one in same function.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/sctp/socket.c 2010-02-18 10:06:57.656887238 -0800
+++ b/net/sctp/socket.c 2010-02-18 10:07:09.894132363 -0800
@@ -5478,7 +5478,7 @@ pp_found:
*/
int reuse = sk->sk_reuse;
struct sock *sk2;
- struct hlist_node *node;
+ struct hlist_node *node2;
SCTP_DEBUG_PRINTK("sctp_get_port() found a possible match\n");
if (pp->fastreuse && sk->sk_reuse &&
@@ -5495,7 +5495,7 @@ pp_found:
* that this port/socket (sk) combination are already
* in an endpoint.
*/
- sk_for_each_bound(sk2, node, &pp->owner) {
+ sk_for_each_bound(sk2, node2, &pp->owner) {
struct sctp_endpoint *ep2;
ep2 = sctp_sk(sk2)->ep;
--
next prev parent reply other threads:[~2010-02-19 5:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100219055520.223027612@vyatta.com>
2010-02-19 5:55 ` [RFC 1/2] sctp: convert hash list to RCU Stephen Hemminger
2010-02-19 5:55 ` Stephen Hemminger
2010-02-19 8:13 ` Eric Dumazet
2010-02-19 8:13 ` Eric Dumazet
2010-02-19 8:41 ` Eric Dumazet
2010-02-19 8:41 ` Eric Dumazet
2010-02-19 15:58 ` Paul E. McKenney
2010-02-19 15:58 ` Paul E. McKenney
2010-02-19 16:18 ` Stephen Hemminger
2010-02-19 16:18 ` Stephen Hemminger
2010-02-19 19:07 ` Paul E. McKenney
2010-02-19 19:07 ` Paul E. McKenney
2010-02-19 17:29 ` Vlad Yasevich
2010-02-19 17:29 ` Vlad Yasevich
2010-02-19 5:55 ` Stephen Hemminger [this message]
2010-02-19 5:55 ` [RFC 2/2] SCTP: fix sparse warning Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219055628.517807379@vyatta.com \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sri@us.ibm.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.