From: "John W. Linville" <linville@tuxdriver.com>
To: Pavel Roskin <proski@gnu.org>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath5k: remove stale function declarations, make some functions static
Date: Fri, 19 Feb 2010 08:44:49 -0500 [thread overview]
Message-ID: <20100219134448.GA2844@tuxdriver.com> (raw)
In-Reply-To: <20100219012802.12460.42239.stgit@mj.roinet.com>
On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote:
> Remove all unnecessary function declarations from ath5k.h. Comment out
> unused functions. Remove ath5k_hw_get_tsf32(), which is too trivial to
> be commented out. Make functions static if suggested by sparse. Make
> ath5k_pm_ops static.
Any reason not to just remove those functions instead of commenting
them out?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-02-19 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 1:28 [PATCH 1/3] ath5k: remove stale function declarations, make some functions static Pavel Roskin
2010-02-19 1:28 ` [PATCH 2/3] ath5k: remove useless "extern" from function declarations Pavel Roskin
2010-02-19 1:28 ` [PATCH 3/3] ath5k: move ath5k_hw_register_timeout() into reset.c Pavel Roskin
2010-02-19 13:23 ` [PATCH 1/3] ath5k: remove stale function declarations, make some functions static Bob Copeland
2010-02-19 13:44 ` John W. Linville [this message]
2010-02-19 23:15 ` Pavel Roskin
2010-02-20 15:30 ` Bob Copeland
2010-02-23 20:17 ` Pavel Roskin
2010-02-23 20:21 ` John W. Linville
2010-02-23 22:55 ` [ath5k-devel] " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219134448.GA2844@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.