From: "John W. Linville" <linville@tuxdriver.com>
To: Pavel Roskin <proski@gnu.org>
Cc: Bob Copeland <me@bobcopeland.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath5k: remove stale function declarations, make some functions static
Date: Tue, 23 Feb 2010 15:21:25 -0500 [thread overview]
Message-ID: <20100223202125.GE2928@tuxdriver.com> (raw)
In-Reply-To: <1266956262.16604.1.camel@mj>
On Tue, Feb 23, 2010 at 03:17:42PM -0500, Pavel Roskin wrote:
> On Sat, 2010-02-20 at 10:30 -0500, Bob Copeland wrote:
> > On Fri, Feb 19, 2010 at 6:15 PM, Pavel Roskin <proski@gnu.org> wrote:
> > > On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote:
> > >> On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote:
> > >> Any reason not to just remove those functions instead of commenting
> > >> them out?
> > >
> > > I'm fine either way. I tend to clean up more aggressively if I know
> > > that nobody will miss that code. I wasn't sure in this case.
> >
> > I don't think it will be a big deal if they disappear. I think most of
> > them are just there because the original HAL had them.
> >
> > Maybe one or two functions are waiting on an API in the stack to be useful
> > (e.g. antenna stuff), but we can always get these routines back from git
> > history if need be.
>
> I see you are doing that work already, so please just tell me if I need
> to resubmit my patches.
Not as far as I'm concerned, but I'll probably delete those sections myself.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-02-23 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 1:28 [PATCH 1/3] ath5k: remove stale function declarations, make some functions static Pavel Roskin
2010-02-19 1:28 ` [PATCH 2/3] ath5k: remove useless "extern" from function declarations Pavel Roskin
2010-02-19 1:28 ` [PATCH 3/3] ath5k: move ath5k_hw_register_timeout() into reset.c Pavel Roskin
2010-02-19 13:23 ` [PATCH 1/3] ath5k: remove stale function declarations, make some functions static Bob Copeland
2010-02-19 13:44 ` John W. Linville
2010-02-19 23:15 ` Pavel Roskin
2010-02-20 15:30 ` Bob Copeland
2010-02-23 20:17 ` Pavel Roskin
2010-02-23 20:21 ` John W. Linville [this message]
2010-02-23 22:55 ` [ath5k-devel] " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223202125.GE2928@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.