From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
Date: Fri, 19 Feb 2010 19:25:17 +0000 [thread overview]
Message-ID: <20100219192517.GA8515@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100219180331.GC21755@atomide.com>
On Fri, Feb 19, 2010 at 10:03:32AM -0800, Tony Lindgren wrote:
> If so, then what have in arch/arm/plat-omap/iommu.c seems buggy:
>
> static void flush_iopgd_range(u32 *first, u32 *last)
> {
> /* FIXME: L2 cache should be taken care of if it exists */
> do {
> asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd"
> : : "r" (first));
> first += L1_CACHE_BYTES / sizeof(*first);
> } while (first <= last);
> }
>
> It seems that this code should use the real cache line size instead to
> avoid every other line not to flush if ARM_L1_CACHE_SHIFT is set larger
> than it is.
Yes.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
Date: Fri, 19 Feb 2010 19:25:17 +0000 [thread overview]
Message-ID: <20100219192517.GA8515@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100219180331.GC21755@atomide.com>
On Fri, Feb 19, 2010 at 10:03:32AM -0800, Tony Lindgren wrote:
> If so, then what have in arch/arm/plat-omap/iommu.c seems buggy:
>
> static void flush_iopgd_range(u32 *first, u32 *last)
> {
> /* FIXME: L2 cache should be taken care of if it exists */
> do {
> asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd"
> : : "r" (first));
> first += L1_CACHE_BYTES / sizeof(*first);
> } while (first <= last);
> }
>
> It seems that this code should use the real cache line size instead to
> avoid every other line not to flush if ARM_L1_CACHE_SHIFT is set larger
> than it is.
Yes.
next prev parent reply other threads:[~2010-02-19 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 0:27 [PATCH] arm: Allow mounting root on omaps with CPU_V6 and CPU_V7 Tony Lindgren
2010-02-19 0:27 ` Tony Lindgren
2010-02-19 8:35 ` Russell King - ARM Linux
2010-02-19 8:35 ` Russell King - ARM Linux
2010-02-19 18:03 ` Tony Lindgren
2010-02-19 18:03 ` Tony Lindgren
2010-02-19 19:25 ` Russell King - ARM Linux [this message]
2010-02-19 19:25 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219192517.GA8515@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.