[PATCH] rdma/nes: set assume_alligned_header bit

[PATCH] rdma/nes: set assume_alligned_header bit

[Faisal Latif]

set assume bit alligned bit in qp context as recommended by hardware group.

Signed-off-by: Faisal Latif <faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/nes/nes_verbs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c
index 64d3136..dba659a 100644
--- a/drivers/infiniband/hw/nes/nes_verbs.c
+++ b/drivers/infiniband/hw/nes/nes_verbs.c
@@ -1325,6 +1325,7 @@ static struct ib_qp *nes_create_qp(struct ib_pd *ibpd,
 			nesqp->nesqp_context->ird_ord_sizes = cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
 					((((u32)nesadapter->max_irrq_wr) <<
 					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));
+			nesqp->nesqp_context->ird_ord_sizes |= cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH);
 			if (disable_mpa_crc) {
 				nes_debug(NES_DBG_QP, "Disabling MPA crc checking due to module option.\n");
 				nesqp->nesqp_context->ird_ord_sizes |= cpu_to_le32(NES_QPCONTEXT_ORDIRD_RNMC);
-- 
1.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma/nes: set assume_alligned_header bit

[Roland Dreier]

 >  			nesqp->nesqp_context->ird_ord_sizes = cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
 >  					((((u32)nesadapter->max_irrq_wr) <<
 >  					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));
 > +			nesqp->nesqp_context->ird_ord_sizes |= cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH);

I think I would just combine this into the existing assignment (which
could also probably be formatted better but I'm not worrying about
this), and write the whole thing as:

 			nesqp->nesqp_context->ird_ord_sizes = cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
					NES_QPCONTEXT_ORDIRD_AAH |
 					((((u32)nesadapter->max_irrq_wr) <<
 					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));

-- 
Roland Dreier  <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] rdma/nes: set assume_alligned_header bit

[Latif, Faisal]

That will be fine.

Thanks
Faisal


>-----Original Message-----
>From: Roland Dreier [mailto:rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org]
>Sent: Friday, February 19, 2010 3:18 PM
>To: Latif, Faisal
>Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>Subject: Re: [PATCH] rdma/nes: set assume_alligned_header bit
>
> >  			nesqp->nesqp_context->ird_ord_sizes =
>cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
> >  					((((u32)nesadapter->max_irrq_wr) <<
> >  					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) &
>NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));
> > +			nesqp->nesqp_context->ird_ord_sizes |=
>cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH);
>
>I think I would just combine this into the existing assignment (which
>could also probably be formatted better but I'm not worrying about
>this), and write the whole thing as:
>
> 			nesqp->nesqp_context->ird_ord_sizes =
>cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
>					NES_QPCONTEXT_ORDIRD_AAH |
> 					((((u32)nesadapter->max_irrq_wr) <<
> 					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) &
>NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));
>
>--
>Roland Dreier  <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
>For corporate legal information go to:
>http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html