All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 09/18] sysctl extern cleanup - file nr
@ 2010-02-20 14:15 Dave Young
  0 siblings, 0 replies; only message in thread
From: Dave Young @ 2010-02-20 14:15 UTC (permalink / raw)
  To: Al Viro, Ingo Molnar, Andrew Morton, Peter Zijlstra, James Morris,
	Eric W. Biederman, linux-kernel

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move sysctl_nr_open_min, sysctl_nr_open_max extern declarations to linux/file.h

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
 include/linux/file.h |    3 +++
 kernel/sysctl.c      |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

--- linux-2.6.32.orig/include/linux/file.h	2010-02-20 14:02:22.601592643 +0800
+++ linux-2.6.32/include/linux/file.h	2010-02-20 14:23:05.188136249 +0800
@@ -9,6 +9,9 @@
 #include <linux/types.h>
 #include <linux/posix_types.h>
 
+#ifdef CONFIG_SYSCTL
+extern int sysctl_nr_open_min, sysctl_nr_open_max;
+#endif
 struct file;
 
 extern void __fput(struct file *);
--- linux-2.6.32.orig/kernel/sysctl.c	2010-02-20 14:17:53.132332896 +0800
+++ linux-2.6.32/kernel/sysctl.c	2010-02-20 14:22:30.728971346 +0800
@@ -60,6 +60,7 @@
 #include <linux/pid.h>
 #include <linux/compat.h>
 #include <linux/latencytop.h>
+#include <linux/file.h>
 
 #include <asm/uaccess.h>
 #include <asm/processor.h>
@@ -74,7 +75,6 @@
 #if defined(CONFIG_SYSCTL)
 
 /* External variables not in a header file. */
-extern int sysctl_nr_open_min, sysctl_nr_open_max;
 #ifdef CONFIG_RCU_TORTURE_TEST
 extern int rcutorture_runnable;
 #endif /* #ifdef CONFIG_RCU_TORTURE_TEST */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-20 14:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 14:15 [PATCH 09/18] sysctl extern cleanup - file nr Dave Young

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.