From: Dave Young <hidave.darkstar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <ak@linux.intel.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Nick Piggin <npiggin@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
James Morris <jmorris@namei.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>
Subject: [PATCH -mm 05/17] sysctl extern cleanup - mm
Date: Sun, 21 Feb 2010 22:23:25 +0800 [thread overview]
Message-ID: <20100221142325.GA3006@darkstar> (raw)
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move min_free_kbytes extern declaration to linux/mmzone.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/linux/mmzone.h | 1 +
kernel/sysctl.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.32.orig/include/linux/mmzone.h 2010-02-21 09:50:34.007270577 +0800
+++ linux-2.6.32/include/linux/mmzone.h 2010-02-21 09:52:21.259760505 +0800
@@ -744,6 +744,7 @@ static inline int is_dma(struct zone *zo
struct ctl_table;
int min_free_kbytes_sysctl_handler(struct ctl_table *, int,
void __user *, size_t *, loff_t *);
+extern int min_free_kbytes; /* for sysctl */
extern int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1];
int lowmem_reserve_ratio_sysctl_handler(struct ctl_table *, int,
void __user *, size_t *, loff_t *);
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 09:48:06.843951983 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-21 09:52:58.139756932 +0800
@@ -72,7 +72,6 @@
/* External variables not in a header file. */
extern int max_threads;
-extern int min_free_kbytes;
extern int compat_log;
extern int latencytop_enabled;
extern int sysctl_nr_open_min, sysctl_nr_open_max;
WARNING: multiple messages have this Message-ID (diff)
From: Dave Young <hidave.darkstar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <ak@linux.intel.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Nick Piggin <npiggin@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
James Morris <jmorris@namei.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>
Subject: [PATCH -mm 05/17] sysctl extern cleanup - mm
Date: Sun, 21 Feb 2010 22:23:25 +0800 [thread overview]
Message-ID: <20100221142325.GA3006@darkstar> (raw)
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move min_free_kbytes extern declaration to linux/mmzone.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/linux/mmzone.h | 1 +
kernel/sysctl.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.32.orig/include/linux/mmzone.h 2010-02-21 09:50:34.007270577 +0800
+++ linux-2.6.32/include/linux/mmzone.h 2010-02-21 09:52:21.259760505 +0800
@@ -744,6 +744,7 @@ static inline int is_dma(struct zone *zo
struct ctl_table;
int min_free_kbytes_sysctl_handler(struct ctl_table *, int,
void __user *, size_t *, loff_t *);
+extern int min_free_kbytes; /* for sysctl */
extern int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1];
int lowmem_reserve_ratio_sysctl_handler(struct ctl_table *, int,
void __user *, size_t *, loff_t *);
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 09:48:06.843951983 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-21 09:52:58.139756932 +0800
@@ -72,7 +72,6 @@
/* External variables not in a header file. */
extern int max_threads;
-extern int min_free_kbytes;
extern int compat_log;
extern int latencytop_enabled;
extern int sysctl_nr_open_min, sysctl_nr_open_max;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-02-21 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 14:23 Dave Young [this message]
2010-02-21 14:23 ` [PATCH -mm 05/17] sysctl extern cleanup - mm Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221142325.GA3006@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.