[PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support
@ 2010-02-22  9:20 Kuninori Morimoto
  2010-02-22 10:22 ` Paul Mundt
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2010-02-22  9:20 UTC (permalink / raw)
  To: linux-sh

Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
---
 arch/arm/mach-shmobile/board-ap4evb.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c
index 41bc248..4714cad 100644
--- a/arch/arm/mach-shmobile/board-ap4evb.c
+++ b/arch/arm/mach-shmobile/board-ap4evb.c
@@ -197,6 +197,20 @@ static void __init ap4evb_init(void)
 	gpio_request(GPIO_FN_CS5A,	NULL);
 	gpio_request(GPIO_FN_IRQ6_39,	NULL);
 
+	/* enable LED 1 - 4 */
+	gpio_request(GPIO_PORT185, NULL);
+	gpio_request(GPIO_PORT186, NULL);
+	gpio_request(GPIO_PORT187, NULL);
+	gpio_request(GPIO_PORT188, NULL);
+	gpio_direction_output(GPIO_PORT185, 1);
+	gpio_direction_output(GPIO_PORT186, 1);
+	gpio_direction_output(GPIO_PORT187, 1);
+	gpio_direction_output(GPIO_PORT188, 1);
+	gpio_export(GPIO_PORT185, 0);
+	gpio_export(GPIO_PORT186, 0);
+	gpio_export(GPIO_PORT187, 0);
+	gpio_export(GPIO_PORT188, 0);
+
 	sh7372_add_standard_devices();
 
 	platform_add_devices(ap4evb_devices, ARRAY_SIZE(ap4evb_devices));
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support
  2010-02-22  9:20 [PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support Kuninori Morimoto
@ 2010-02-22 10:22 ` Paul Mundt
  2011-02-15  5:03 ` [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory initialize for Kuninori Morimoto
  2011-02-17  0:43 ` [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2010-02-22 10:22 UTC (permalink / raw)
  To: linux-sh

On Mon, Feb 22, 2010 at 06:20:39PM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
>  arch/arm/mach-shmobile/board-ap4evb.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c
> index 41bc248..4714cad 100644
> --- a/arch/arm/mach-shmobile/board-ap4evb.c
> +++ b/arch/arm/mach-shmobile/board-ap4evb.c
> @@ -197,6 +197,20 @@ static void __init ap4evb_init(void)
>  	gpio_request(GPIO_FN_CS5A,	NULL);
>  	gpio_request(GPIO_FN_IRQ6_39,	NULL);
>  
> +	/* enable LED 1 - 4 */
> +	gpio_request(GPIO_PORT185, NULL);

[snip]

On Mon, Feb 22, 2010 at 06:30:12PM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
>  arch/arm/mach-shmobile/board-ap4evb.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c
> index 4714cad..d9a46d0 100644
> --- a/arch/arm/mach-shmobile/board-ap4evb.c
> +++ b/arch/arm/mach-shmobile/board-ap4evb.c
> @@ -211,6 +211,20 @@ static void __init ap4evb_init(void)
>  	gpio_export(GPIO_PORT187, 0);
>  	gpio_export(GPIO_PORT188, 0);
>  
> +	/* enable Debug switch (S6) */
> +	gpio_request(GPIO_PORT32, NULL);

[snip]

Both applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory initialize for
  2010-02-22  9:20 [PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support Kuninori Morimoto
  2010-02-22 10:22 ` Paul Mundt
@ 2011-02-15  5:03 ` Kuninori Morimoto
  2011-02-17  0:43 ` [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2011-02-15  5:03 UTC (permalink / raw)
  To: linux-sh

Current ap4evb had issue which couldn't boot sometimes.
This patch fixup it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../arm/mach-shmobile/include/mach/head-ap4evb.txt |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-shmobile/include/mach/head-ap4evb.txt b/arch/arm/mach-shmobile/include/mach/head-ap4evb.txt
index efd3687..3029aba 100644
--- a/arch/arm/mach-shmobile/include/mach/head-ap4evb.txt
+++ b/arch/arm/mach-shmobile/include/mach/head-ap4evb.txt
@@ -6,13 +6,10 @@ LIST "RWT Setting"
 EW 0xE6020004, 0xA500
 EW 0xE6030004, 0xA500
 
-DD 0x01001000, 0x01001000
-
 LIST "GPIO Setting"
 EB 0xE6051013, 0xA2
 
 LIST "CPG"
-ED 0xE6150080, 0x00000180
 ED 0xE61500C0, 0x00000002
 
 WAIT 1, 0xFE40009C
@@ -37,6 +34,9 @@ ED 0xE615002C, 0x93000040
 
 WAIT 1, 0xFE40009C
 
+LIST "SUB/USBClk"
+ED 0xE6150080, 0x00000180
+
 LIST "BSC"
 ED 0xFEC10000, 0x00E0001B
 
@@ -53,7 +53,7 @@ ED 0xFE400048, 0x20C18505
 ED 0xFE40004C, 0x00110209
 ED 0xFE400010, 0x00000087
 
-WAIT 10, 0xFE40009C
+WAIT 30, 0xFE40009C
 
 ED 0xFE400084, 0x0000003F
 EB 0xFE500000, 0x00
@@ -84,7 +84,7 @@ ED 0xE6150004, 0x80331050
 
 WAIT 1, 0xFE40009C
 
-ED 0xE6150354, 0x00000002
+ED 0xFE400354, 0x01AD8002
 
 LIST "SCIF0 - Serial port for earlyprintk"
 EB 0xE6053098, 0x11
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory
  2010-02-22  9:20 [PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support Kuninori Morimoto
  2010-02-22 10:22 ` Paul Mundt
  2011-02-15  5:03 ` [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory initialize for Kuninori Morimoto
@ 2011-02-17  0:43 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2011-02-17  0:43 UTC (permalink / raw)
  To: linux-sh

On Tue, Feb 15, 2011 at 02:03:46PM +0900, Kuninori Morimoto wrote:
> Current ap4evb had issue which couldn't boot sometimes.
> This patch fixup it.

Hi Morimoto-san,

As per the Mackerel version of this patch,
I have looked over the register changes
and they seem reasonable to me.

I do not have an AP4EB available to test this code at this time.
(I think that the AP4EB that I previously used is sitting on/near
Magnus's desk.)

Reviewed-by: Simon Horman <horms@verge.net.au>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-02-17  0:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-22  9:20 [PATCH 1/2] ARM: mach-shmobile: ap4evb: Add LED support Kuninori Morimoto
2010-02-22 10:22 ` Paul Mundt
2011-02-15  5:03 ` [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory initialize for Kuninori Morimoto
2011-02-17  0:43 ` [PATCH 1/2] ARM: mach-shmobile: ap4evb: fixup memory Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.