From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 6/6] KVM: x86: Emulator support for TF
Date: Tue, 23 Feb 2010 12:32:53 +0200 [thread overview]
Message-ID: <20100223103253.GH29041@redhat.com> (raw)
In-Reply-To: <4B83AE05.3070505@redhat.com>
On Tue, Feb 23, 2010 at 12:29:25PM +0200, Avi Kivity wrote:
> On 02/23/2010 12:26 PM, Gleb Natapov wrote:
> >On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote:
> >>Gleb Natapov wrote:
> >>>On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote:
> >>>>Support both guest- as well as host-owned EFLAGS.TF while emulating
> >>>>instructions. For guest-owned TF, we simply inject DB and update DR6.BS
> >>>>after completing an instruction that has TF set on entry. To support
> >>>>guest single-stepping under host control, we store the pending step
> >>>>along with its CS and RIP and trigger a corresponding user space exit
> >>>>once guest execution is about to resume. This check is is also required
> >>>>in the VMX emulation loop during invalid guest states.
> >>>>
> >>>Emulator currently is a total mess. It is not a good time to add more mess
> >>>there right now IMO.
> >>Then let's clean up what you consider "mess" in this feature. Unless
> >>there are plans to clean up the emulator for the next or next-but-one
> >>kernel release, I do not want to wait for this.
> >>
> >There are plans to cleanup the emulator.
>
> That shouldn't stop the code.
>
If the code is correct and doesn't make emulator code even messier.
--
Gleb.
next prev parent reply other threads:[~2010-02-23 10:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 17:51 [PATCH 0/6] KVM: Enhancements and fixes around guest debugging Jan Kiszka
2010-02-22 17:51 ` [PATCH 1/6] KVM: VMX: Update instruction length on intercepted BP Jan Kiszka
2010-02-22 17:51 ` [PATCH 2/6] KVM: SVM: Emulate nRIP feature when reinjecting INT3 Jan Kiszka
2010-02-23 10:13 ` Gleb Natapov
2010-02-23 10:17 ` Jan Kiszka
2010-02-23 10:23 ` Avi Kivity
2010-02-22 17:51 ` [PATCH 3/6] KVM: x86: Add KVM_CAP_X86_ROBUST_SINGLESTEP Jan Kiszka
2010-02-22 17:51 ` [PATCH 4/6] KVM: x86: Drop RF manipulation for guest single-stepping Jan Kiszka
2010-02-22 17:51 ` [PATCH 5/6] KVM: x86: Preserve injected TF across emulation Jan Kiszka
2010-02-23 10:00 ` Gleb Natapov
2010-02-23 10:13 ` Jan Kiszka
2010-02-23 10:31 ` Gleb Natapov
2010-02-23 10:40 ` Jan Kiszka
2010-02-23 11:03 ` Gleb Natapov
2010-02-22 17:51 ` [PATCH 6/6] KVM: x86: Emulator support for TF Jan Kiszka
2010-02-23 9:55 ` Gleb Natapov
2010-02-23 10:10 ` Jan Kiszka
2010-02-23 10:26 ` Gleb Natapov
2010-02-23 10:29 ` Avi Kivity
2010-02-23 10:32 ` Gleb Natapov [this message]
2010-02-23 10:34 ` Avi Kivity
2010-02-23 10:37 ` Jan Kiszka
2010-02-23 11:00 ` Gleb Natapov
2010-02-23 11:04 ` Avi Kivity
2010-02-23 11:30 ` Jan Kiszka
2010-02-23 11:41 ` Avi Kivity
2010-02-23 12:03 ` Jan Kiszka
2010-02-23 12:05 ` Gleb Natapov
2010-02-23 12:02 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223103253.GH29041@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.