From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 6/6] KVM: x86: Emulator support for TF
Date: Tue, 23 Feb 2010 13:03:42 +0100 [thread overview]
Message-ID: <4B83C41E.30207@siemens.com> (raw)
In-Reply-To: <4B83BEF8.5050503@redhat.com>
Avi Kivity wrote:
> On 02/23/2010 01:30 PM, Jan Kiszka wrote:
>>> How to detect that emulation is complete? emulate_instruction() should
>>> return EMULATE_DONE in this case.
>>>
>> ...*and* RIP moved forward.
>>
>
> A branch or rep instruction can successfully execute and not change rip.
>
> Btw, do we expect a #DB on every iteration of rep? In this case we need
> to modify the code, currently we'll batch rep;ins and rep;outs up to a
> page's worth.
Right, TF triggers after each rep step. So we need to break this up when
tracing is on. That's now definitely something we need a deeper emulator
change.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2010-02-23 12:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 17:51 [PATCH 0/6] KVM: Enhancements and fixes around guest debugging Jan Kiszka
2010-02-22 17:51 ` [PATCH 1/6] KVM: VMX: Update instruction length on intercepted BP Jan Kiszka
2010-02-22 17:51 ` [PATCH 2/6] KVM: SVM: Emulate nRIP feature when reinjecting INT3 Jan Kiszka
2010-02-23 10:13 ` Gleb Natapov
2010-02-23 10:17 ` Jan Kiszka
2010-02-23 10:23 ` Avi Kivity
2010-02-22 17:51 ` [PATCH 3/6] KVM: x86: Add KVM_CAP_X86_ROBUST_SINGLESTEP Jan Kiszka
2010-02-22 17:51 ` [PATCH 4/6] KVM: x86: Drop RF manipulation for guest single-stepping Jan Kiszka
2010-02-22 17:51 ` [PATCH 5/6] KVM: x86: Preserve injected TF across emulation Jan Kiszka
2010-02-23 10:00 ` Gleb Natapov
2010-02-23 10:13 ` Jan Kiszka
2010-02-23 10:31 ` Gleb Natapov
2010-02-23 10:40 ` Jan Kiszka
2010-02-23 11:03 ` Gleb Natapov
2010-02-22 17:51 ` [PATCH 6/6] KVM: x86: Emulator support for TF Jan Kiszka
2010-02-23 9:55 ` Gleb Natapov
2010-02-23 10:10 ` Jan Kiszka
2010-02-23 10:26 ` Gleb Natapov
2010-02-23 10:29 ` Avi Kivity
2010-02-23 10:32 ` Gleb Natapov
2010-02-23 10:34 ` Avi Kivity
2010-02-23 10:37 ` Jan Kiszka
2010-02-23 11:00 ` Gleb Natapov
2010-02-23 11:04 ` Avi Kivity
2010-02-23 11:30 ` Jan Kiszka
2010-02-23 11:41 ` Avi Kivity
2010-02-23 12:03 ` Jan Kiszka [this message]
2010-02-23 12:05 ` Gleb Natapov
2010-02-23 12:02 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B83C41E.30207@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.