From: Greg KH <greg@kroah.com>
To: Narendra K <Narendra_K@dell.com>
Cc: netdev@vger.kernel.org, linux-hotplug@vger.kernel.org,
linux-pci@vger.kernel.org, matt_domsch@dell.com,
jordan_hargrave@dell.com, sandeep_k_shandilya@dell.com,
charles_rose@dell.com, shyam_iyer@dell.com
Subject: Re: [PATCH] Export smbios strings associated with onboard devices
Date: Thu, 25 Feb 2010 22:55:33 +0000 [thread overview]
Message-ID: <20100225225533.GA20900@kroah.com> (raw)
In-Reply-To: <20100225202941.GA19404@mock.linuxdev.us.dell.com>
On Thu, Feb 25, 2010 at 02:29:42PM -0600, Narendra K wrote:
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -419,6 +419,11 @@ static int device_add_attrs(struct bus_type *bus, struct device *dev)
> return 0;
>
> for (i = 0; attr_name(bus->dev_attrs[i]); i++) {
> + /* if the device does not have an associated smbios string in the smbios table, do not create this attribute */
> + if (!(strcmp(attr_name(bus->dev_attrs[i]), "smbiosname"))) {
> + if (!smbiosname_string_is_valid(dev, NULL))
> + continue;
> + }
Um, no, you can not modify the driver core for stuff like this. Do it
in your driver or class specific code, as that is where it is supposed
to be.
good luck,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Narendra K <Narendra_K@dell.com>
Cc: netdev@vger.kernel.org, linux-hotplug@vger.kernel.org,
linux-pci@vger.kernel.org, matt_domsch@dell.com,
jordan_hargrave@dell.com, sandeep_k_shandilya@dell.com,
charles_rose@dell.com, shyam_iyer@dell.com
Subject: Re: [PATCH] Export smbios strings associated with onboard devices to sysfs
Date: Thu, 25 Feb 2010 14:55:33 -0800 [thread overview]
Message-ID: <20100225225533.GA20900@kroah.com> (raw)
In-Reply-To: <20100225202941.GA19404@mock.linuxdev.us.dell.com>
On Thu, Feb 25, 2010 at 02:29:42PM -0600, Narendra K wrote:
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -419,6 +419,11 @@ static int device_add_attrs(struct bus_type *bus, struct device *dev)
> return 0;
>
> for (i = 0; attr_name(bus->dev_attrs[i]); i++) {
> + /* if the device does not have an associated smbios string in the smbios table, do not create this attribute */
> + if (!(strcmp(attr_name(bus->dev_attrs[i]), "smbiosname"))) {
> + if (!smbiosname_string_is_valid(dev, NULL))
> + continue;
> + }
Um, no, you can not modify the driver core for stuff like this. Do it
in your driver or class specific code, as that is where it is supposed
to be.
good luck,
greg k-h
next prev parent reply other threads:[~2010-02-25 22:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 20:29 [PATCH] Export smbios strings associated with onboard devices to Narendra K
2010-02-25 20:29 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Narendra K
2010-02-25 20:49 ` [PATCH] Export smbios strings associated with onboard devices to Domsch, Matt
2010-02-25 20:49 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Domsch, Matt
[not found] ` <EDA0A4495861324DA2618B4C45DCB3EE6122A2@blrx3m08.blr.amer.dell.com>
2010-03-02 17:33 ` [PATCH] Export smbios strings associated with onboard devices Narendra K
2010-03-02 17:33 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Narendra K
2010-03-02 18:28 ` [PATCH] Export smbios strings associated with onboard devices Greg KH
2010-03-02 18:28 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Greg KH
2010-03-08 17:34 ` [PATCH] Export smbios strings associated with onboard devices Alex Chiang
2010-03-08 17:34 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Alex Chiang
2010-03-08 17:38 ` [PATCH] Export smbios strings associated with onboard devices Alex Chiang
2010-03-08 17:38 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Alex Chiang
2010-03-08 17:57 ` [PATCH] Export smbios strings associated with onboard devicesto sysfs Narendra_K
2010-03-08 17:57 ` Narendra_K
2010-02-25 21:40 ` [PATCH] Export smbios strings associated with onboard devices Alex Chiang
2010-02-25 21:40 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Alex Chiang
2010-02-25 21:46 ` [PATCH] Export smbios strings associated with onboard devices to Domsch, Matt
2010-02-25 21:46 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Domsch, Matt
2010-02-25 22:20 ` [PATCH] Export smbios strings associated with onboard devices Alex Chiang
2010-02-25 22:20 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Alex Chiang
2010-03-02 17:42 ` [PATCH] Export smbios strings associated with onboard devicesto sysfs Narendra_K
2010-03-02 17:54 ` Narendra_K
2010-02-25 22:55 ` Greg KH [this message]
2010-02-25 22:55 ` [PATCH] Export smbios strings associated with onboard devices to sysfs Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225225533.GA20900@kroah.com \
--to=greg@kroah.com \
--cc=Narendra_K@dell.com \
--cc=charles_rose@dell.com \
--cc=jordan_hargrave@dell.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt_domsch@dell.com \
--cc=netdev@vger.kernel.org \
--cc=sandeep_k_shandilya@dell.com \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.