All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Christoph Lameter <cl@linux-foundation.org>,
	Frans Pop <elendil@planet.nl>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Memory management woes - order 1 allocation failures
Date: Tue, 2 Mar 2010 11:29:42 -0800	[thread overview]
Message-ID: <20100302192942.GA2953@suse.de> (raw)
In-Reply-To: <20100302191110.GB11355@csn.ul.ie>

On Tue, Mar 02, 2010 at 07:11:10PM +0000, Mel Gorman wrote:
> On Tue, Mar 02, 2010 at 06:34:51PM +0000, Alan Cox wrote:
> > > For reasons that are not particularly clear to me, tty_buffer_alloc() is
> > > called far more frequently in 2.6.33 than in 2.6.24. I instrumented the
> > > function to print out the size of the buffers allocated, booted under
> > > qemu and would just "cat /bin/ls" to see what buffers were allocated.
> > > 2.6.33 allocates loads, including high-order allocations. 2.6.24
> > > appeared to allocate once and keep silent.
> > 
> > The pty layer is using them now and didn't before. That will massively
> > distort your numhers.
> > 
> 
> That makes perfect sense. It explains why only one allocation showed up
> because it must belong to the tty attached to the serial console.
> 
> Thanks Alan.
> 
> > > While there have been snags recently with respect to high-order
> > > allocation failures in recent kernels, this might be one of the cases
> > > where it's due to subsystems requesting high-order allocations more.
> > 
> > The pty code certainly triggered more such allocations. I've sent Greg
> > patches to make the tty buffering layer allocate sensible sizes as it
> > doesn't need multiple page allocations in the first place.
> > 
> 
> Greg, what's the story with these patches?

They are in -next and will go to Linus later on today for .34.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Christoph Lameter <cl@linux-foundation.org>,
	Frans Pop <elendil@planet.nl>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Memory management woes - order 1 allocation failures
Date: Tue, 2 Mar 2010 11:29:42 -0800	[thread overview]
Message-ID: <20100302192942.GA2953@suse.de> (raw)
In-Reply-To: <20100302191110.GB11355@csn.ul.ie>

On Tue, Mar 02, 2010 at 07:11:10PM +0000, Mel Gorman wrote:
> On Tue, Mar 02, 2010 at 06:34:51PM +0000, Alan Cox wrote:
> > > For reasons that are not particularly clear to me, tty_buffer_alloc() is
> > > called far more frequently in 2.6.33 than in 2.6.24. I instrumented the
> > > function to print out the size of the buffers allocated, booted under
> > > qemu and would just "cat /bin/ls" to see what buffers were allocated.
> > > 2.6.33 allocates loads, including high-order allocations. 2.6.24
> > > appeared to allocate once and keep silent.
> > 
> > The pty layer is using them now and didn't before. That will massively
> > distort your numhers.
> > 
> 
> That makes perfect sense. It explains why only one allocation showed up
> because it must belong to the tty attached to the serial console.
> 
> Thanks Alan.
> 
> > > While there have been snags recently with respect to high-order
> > > allocation failures in recent kernels, this might be one of the cases
> > > where it's due to subsystems requesting high-order allocations more.
> > 
> > The pty code certainly triggered more such allocations. I've sent Greg
> > patches to make the tty buffering layer allocate sensible sizes as it
> > doesn't need multiple page allocations in the first place.
> > 
> 
> Greg, what's the story with these patches?

They are in -next and will go to Linus later on today for .34.

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-03-02 19:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26 11:32 Memory management woes - order 1 allocation failures Frans Pop
2010-02-26 12:24 ` Frans Pop
2010-02-26 12:24   ` Frans Pop
2010-02-26 14:01 ` Pekka Enberg
2010-02-26 14:01   ` Pekka Enberg
2010-02-26 15:33   ` Frans Pop
2010-02-26 15:33     ` Frans Pop
2010-02-26 16:43     ` Christoph Lameter
2010-02-26 16:43       ` Christoph Lameter
2010-02-26 17:17       ` Pekka Enberg
2010-02-26 17:17         ` Pekka Enberg
2010-03-01  1:42         ` KOSAKI Motohiro
2010-03-01  1:42           ` KOSAKI Motohiro
2010-03-02 17:26           ` Mel Gorman
2010-03-02 17:26             ` Mel Gorman
2010-03-02 18:34             ` Alan Cox
2010-03-02 18:34               ` Alan Cox
2010-03-02 19:11               ` Mel Gorman
2010-03-02 19:11                 ` Mel Gorman
2010-03-02 19:29                 ` Greg KH [this message]
2010-03-02 19:29                   ` Greg KH
2010-03-02 21:16                   ` Mel Gorman
2010-03-02 21:16                     ` Mel Gorman
2010-03-02 22:17                     ` Alan Cox
2010-03-02 22:17                       ` Alan Cox
2010-03-02 22:29                       ` Mel Gorman
2010-03-02 22:29                         ` Mel Gorman
2010-03-12  3:32                         ` Frans Pop
2010-03-12  3:32                           ` Frans Pop
2010-03-02 23:31               ` KOSAKI Motohiro
2010-03-02 23:31                 ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100302192942.GA2953@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cl@linux-foundation.org \
    --cc=elendil@planet.nl \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.