All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rdunlap@xenotime.net
Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-next@vger.kernel.org
Subject: Re: [Bridge] [PATCH -next] bridge: depends on INET
Date: Wed, 03 Mar 2010 01:23:59 -0800 (PST)	[thread overview]
Message-ID: <20100303.012359.66790294.davem@davemloft.net> (raw)
In-Reply-To: <4B8D4607.8070603@xenotime.net>

From: Randy Dunlap <rdunlap@xenotime.net>
Date: Tue, 02 Mar 2010 09:08:23 -0800

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> br_multicast calls ip_send_check(), so it should depend on INET.
> 
> built-in:
> br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check'
> 
> or modular:
> ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, but I almost lost this patch.

You need to CC: netdev on all networking patches so that it
gets properly tracked in patchwork and therefore does not get
lost.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: rdunlap@xenotime.net
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, shemminger@linux-foundation.org,
	bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH -next] bridge: depends on INET
Date: Wed, 03 Mar 2010 01:23:59 -0800 (PST)	[thread overview]
Message-ID: <20100303.012359.66790294.davem@davemloft.net> (raw)
In-Reply-To: <4B8D4607.8070603@xenotime.net>

From: Randy Dunlap <rdunlap@xenotime.net>
Date: Tue, 02 Mar 2010 09:08:23 -0800

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> br_multicast calls ip_send_check(), so it should depend on INET.
> 
> built-in:
> br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check'
> 
> or modular:
> ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, but I almost lost this patch.

You need to CC: netdev on all networking patches so that it
gets properly tracked in patchwork and therefore does not get
lost.

Thanks.

  reply	other threads:[~2010-03-03  9:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02  7:09 linux-next: Tree for March 2 Stephen Rothwell
2010-03-02 17:08 ` [Bridge] [PATCH -next] bridge: depends on INET Randy Dunlap
2010-03-02 17:08   ` Randy Dunlap
2010-03-03  9:23   ` David Miller [this message]
2010-03-03  9:23     ` David Miller
2010-03-04  3:18     ` [Bridge] " Ingo Molnar
2010-03-04  3:18       ` Ingo Molnar
2010-03-04  4:00       ` [Bridge] " Randy Dunlap
2010-03-04  4:00         ` Randy Dunlap
2010-03-04  8:42       ` [Bridge] " David Miller
2010-03-04  8:42         ` David Miller
2010-03-02 17:12 ` linux-next: Tree for March 2 (watchdog) Randy Dunlap
2010-03-02 20:46   ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100303.012359.66790294.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.