* [patch] cassini: fix off by one
@ 2010-03-03 8:22 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-03 8:22 UTC (permalink / raw)
To: netdev
Cc: Alexey Dobriyan, Andrew Morton, Yang Hongyang, Patrick McHardy,
David S. Miller, linux-kernel, kernel-janitors
There are only 6 link_modes.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 7cbcfb0..9bd155e 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -5072,7 +5072,7 @@ static int __devinit cas_init_one(struct pci_dev *pdev,
INIT_WORK(&cp->reset_task, cas_reset_task);
/* Default link parameters */
- if (link_mode >= 0 && link_mode <= 6)
+ if (link_mode >= 0 && link_mode < 6)
cp->link_cntl = link_modes[link_mode];
else
cp->link_cntl = BMCR_ANENABLE;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] cassini: fix off by one
@ 2010-03-03 8:22 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-03 8:22 UTC (permalink / raw)
To: netdev
Cc: Alexey Dobriyan, Andrew Morton, Yang Hongyang, Patrick McHardy,
David S. Miller, linux-kernel, kernel-janitors
There are only 6 link_modes.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 7cbcfb0..9bd155e 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -5072,7 +5072,7 @@ static int __devinit cas_init_one(struct pci_dev *pdev,
INIT_WORK(&cp->reset_task, cas_reset_task);
/* Default link parameters */
- if (link_mode >= 0 && link_mode <= 6)
+ if (link_mode >= 0 && link_mode < 6)
cp->link_cntl = link_modes[link_mode];
else
cp->link_cntl = BMCR_ANENABLE;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] cassini: fix off by one
2010-03-03 8:22 ` Dan Carpenter
@ 2010-03-03 9:07 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-03 9:07 UTC (permalink / raw)
To: error27
Cc: netdev, adobriyan, akpm, yanghy, kaber, linux-kernel,
kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 3 Mar 2010 11:22:41 +0300
> There are only 6 link_modes.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] cassini: fix off by one
@ 2010-03-03 9:07 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-03 9:07 UTC (permalink / raw)
To: error27
Cc: netdev, adobriyan, akpm, yanghy, kaber, linux-kernel,
kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 3 Mar 2010 11:22:41 +0300
> There are only 6 link_modes.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] cassini: fix off by one
2010-03-03 9:07 ` David Miller
@ 2010-03-03 15:22 ` Jaswinder Singh Rajput
-1 siblings, 0 replies; 8+ messages in thread
From: Jaswinder Singh Rajput @ 2010-03-03 15:10 UTC (permalink / raw)
To: David Miller
Cc: error27, netdev, adobriyan, akpm, yanghy, kaber, linux-kernel,
kernel-janitors
Hello Dave and Dan,
On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Dan Carpenter <error27@gmail.com>
> Date: Wed, 3 Mar 2010 11:22:41 +0300
>
>> There are only 6 link_modes.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Applied.
I am curious should we add these kind of email address in git log.
error27 seems error to me ;-)
Can we make Signed-off address little bit more sensible.
Thanks,
--
Jaswinder
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] cassini: fix off by one
@ 2010-03-03 15:22 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 8+ messages in thread
From: Jaswinder Singh Rajput @ 2010-03-03 15:22 UTC (permalink / raw)
To: David Miller
Cc: error27, netdev, adobriyan, akpm, yanghy, kaber, linux-kernel,
kernel-janitors
Hello Dave and Dan,
On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Dan Carpenter <error27@gmail.com>
> Date: Wed, 3 Mar 2010 11:22:41 +0300
>
>> There are only 6 link_modes.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Applied.
I am curious should we add these kind of email address in git log.
error27 seems error to me ;-)
Can we make Signed-off address little bit more sensible.
Thanks,
--
Jaswinder
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] cassini: fix off by one
2010-03-03 15:22 ` Jaswinder Singh Rajput
@ 2010-03-03 15:17 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-03 15:17 UTC (permalink / raw)
To: jaswinderlinux
Cc: error27, netdev, adobriyan, akpm, yanghy, kaber, linux-kernel,
kernel-janitors
From: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Date: Wed, 3 Mar 2010 20:40:18 +0530
> Hello Dave and Dan,
>
> On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
>> From: Dan Carpenter <error27@gmail.com>
>> Date: Wed, 3 Mar 2010 11:22:41 +0300
>>
>>> There are only 6 link_modes.
>>>
>>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>>
>> Applied.
>
> I am curious should we add these kind of email address in git log.
> error27 seems error to me ;-)
>
> Can we make Signed-off address little bit more sensible.
Some people have silly email addresses, that is their choice.
I can't see any reason to apply censorship to an email address
just because the character sequences in it have some kind of
meaning.
The email address I was using up until 6 or 7 years ago used a host
name that meant "shit" in the Polish languange.
Maybe I should have been censored too?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] cassini: fix off by one
@ 2010-03-03 15:17 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-03 15:17 UTC (permalink / raw)
To: jaswinderlinux
Cc: error27, netdev, adobriyan, akpm, yanghy, kaber, linux-kernel,
kernel-janitors
From: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Date: Wed, 3 Mar 2010 20:40:18 +0530
> Hello Dave and Dan,
>
> On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
>> From: Dan Carpenter <error27@gmail.com>
>> Date: Wed, 3 Mar 2010 11:22:41 +0300
>>
>>> There are only 6 link_modes.
>>>
>>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>>
>> Applied.
>
> I am curious should we add these kind of email address in git log.
> error27 seems error to me ;-)
>
> Can we make Signed-off address little bit more sensible.
Some people have silly email addresses, that is their choice.
I can't see any reason to apply censorship to an email address
just because the character sequences in it have some kind of
meaning.
The email address I was using up until 6 or 7 years ago used a host
name that meant "shit" in the Polish languange.
Maybe I should have been censored too?
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-03-03 15:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-03 8:22 [patch] cassini: fix off by one Dan Carpenter
2010-03-03 8:22 ` Dan Carpenter
2010-03-03 9:07 ` David Miller
2010-03-03 9:07 ` David Miller
2010-03-03 15:10 ` Jaswinder Singh Rajput
2010-03-03 15:22 ` Jaswinder Singh Rajput
2010-03-03 15:17 ` David Miller
2010-03-03 15:17 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.