All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@nokia.com>
To: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook
Date: Thu, 4 Mar 2010 09:44:34 +0200	[thread overview]
Message-ID: <20100304074434.GI15954@nokia.com> (raw)
In-Reply-To: <1267688416-5998-2-git-send-email-felipe.balbi@nokia.com>

On Thu, Mar 04, 2010 at 08:40:16AM +0100, Balbi Felipe (Nokia-D/Helsinki) wrote:
>From: Felipe Balbi <felipe.balbi@nokia.com>
>
>the early_param() call in board-omap3touchbook.c expands to:
>
>static const char __setup_str_early_touchbook_revision[]
>	__section(.init.rodata) _aligned(1) = tbr;
>[...]
>
>and we have a non-const variable being added to the
>same section:
>
>static struct ehci_hcd_omap_platform_data ehci_pdata
>__section(.init.rodata);
>
>because of that, gcc generates a section type conflict
>which can (and actually should) be avoided by marking
>const every variable marked with __initconst.
>
>This patch fixes that for the ehci_hdc_omap_platform_data.
>
>Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>

missed one git add, sorry. Resending this one only.

-- 
balbi

  reply	other threads:[~2010-03-04  7:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04  7:40 [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" felipe.balbi
2010-03-04  7:40 ` [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook felipe.balbi
2010-03-04  7:44   ` Felipe Balbi [this message]
2010-03-04  7:45     ` felipe.balbi
2010-03-04 13:03       ` Gadiyar, Anand
2010-03-04 19:15         ` me
2010-03-05  7:03           ` Felipe Balbi
2010-03-08 23:04             ` Tony Lindgren
2010-03-09 14:30               ` Felipe Balbi
2010-03-09 15:38                 ` Tony Lindgren
2010-03-09 15:47                   ` Felipe Balbi
2010-03-10  0:48                     ` Tony Lindgren
2010-03-10  6:22                       ` Felipe Balbi
2010-03-10 17:15                         ` Tony Lindgren
2010-03-11  7:28                           ` Felipe Balbi
2010-03-11 16:38                             ` Tony Lindgren
2010-03-04  7:50 ` [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" Felipe Balbi
2010-03-04  7:57   ` [PATCH 1/2] Manual revert of " felipe.balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304074434.GI15954@nokia.com \
    --to=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.