From: Felipe Balbi <me@felipebalbi.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <me@felipebalbi.com>,
Felipe Balbi <felipe.balbi@nokia.com>,
"Gadiyar, Anand" <gadiyar@ti.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook
Date: Tue, 9 Mar 2010 17:47:55 +0200 [thread overview]
Message-ID: <20100309154754.GI3851@gandalf> (raw)
In-Reply-To: <20100309153827.GR2900@atomide.com>
On Tue, Mar 09, 2010 at 07:38:27AM -0800, Tony Lindgren wrote:
> But sounds like your fix to mark anything going to init.rodata as const
> is correct since it is rodata. I was originally thinking this is somehow
> related to __init vs __initconst, but it's for __initconst only, and
> we should use const there as it's read only.
>
> Let me take another look at your patches and make sure everything
> compiles OK, I don't think we're using __initconst in that many places.
the problem is when you put const and non-const variables inside
.init.rodata section. gcc manual might have something about that.
--
balbi
next prev parent reply other threads:[~2010-03-09 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 7:40 [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" felipe.balbi
2010-03-04 7:40 ` [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook felipe.balbi
2010-03-04 7:44 ` Felipe Balbi
2010-03-04 7:45 ` felipe.balbi
2010-03-04 13:03 ` Gadiyar, Anand
2010-03-04 19:15 ` me
2010-03-05 7:03 ` Felipe Balbi
2010-03-08 23:04 ` Tony Lindgren
2010-03-09 14:30 ` Felipe Balbi
2010-03-09 15:38 ` Tony Lindgren
2010-03-09 15:47 ` Felipe Balbi [this message]
2010-03-10 0:48 ` Tony Lindgren
2010-03-10 6:22 ` Felipe Balbi
2010-03-10 17:15 ` Tony Lindgren
2010-03-11 7:28 ` Felipe Balbi
2010-03-11 16:38 ` Tony Lindgren
2010-03-04 7:50 ` [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" Felipe Balbi
2010-03-04 7:57 ` [PATCH 1/2] Manual revert of " felipe.balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309154754.GI3851@gandalf \
--to=me@felipebalbi.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.