Re: [PATCH] cleanup __generic_block_fiemap and fix a few minor issues

[Randy Dunlap <randy.dunlap@oracle.com>]

On Thu, 4 Mar 2010 11:20:40 -0500 Josef Bacik wrote:

> Ahh yes thats much nicer, thank you.  Here is my updated patch with your
> suggestions.  Thanks,
> 
> Signed-off-by: Josef Bacik <josef@redhat.com>
> ---
>  fs/ioctl.c         |   81 +++++++++++++++++++++++++++++----------------------
>  include/linux/fs.h |    5 ++-
>  2 files changed, 49 insertions(+), 37 deletions(-)
> 
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 6c75110..64fed0b 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -228,13 +228,22 @@ static int ioctl_fiemap(struct file *filp, unsigned long arg)
>  
>  #ifdef CONFIG_BLOCK
>  
> -#define blk_to_logical(inode, blk) (blk << (inode)->i_blkbits)
> -#define logical_to_blk(inode, offset) (offset >> (inode)->i_blkbits);
> +static inline sector_t logical_to_blk(struct inode *inode, loff_t offset)
> +{
> +	return (offset >> inode->i_blkbits);
> +}
> +
> +static inline loff_t blk_to_logical(struct inode *inode, sector_t blk)
> +{
> +	return (blk << inode->i_blkbits);
> +}
>  
>  /**
>   * __generic_block_fiemap - FIEMAP for block based inodes (no locking)
>   * @inode - the inode to map
> - * @arg - the pointer to userspace where we copy everything to
> + * @fieinfo - the fiemap info struct that will be passed back to userspace
> + * @start - where to start mapping in the inode
> + * @len - how much space to map
>   * @get_block - the fs's get_block function
>   *
>   * This does FIEMAP for block based inodes.  Basically it will just loop

Please fix the kernel-doc notation.  Function parameter notation is like:

 * @start: where to start mapping in the inode

thanks,
---
~Randy