From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Nick Andrew <nick@nick-andrew.net>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
netdev@vger.kernel.org
Subject: Re: [RESEND PATCH 0/2] Make functions of dev_<level> macros, recursive vsnprintf
Date: Thu, 4 Mar 2010 14:38:37 -0800 [thread overview]
Message-ID: <20100304143837.af39845d.akpm@linux-foundation.org> (raw)
In-Reply-To: <cover.1267682641.git.joe@perches.com>
On Wed, 3 Mar 2010 22:27:21 -0800
Joe Perches <joe@perches.com> wrote:
> (Typo'ed Linus' email address, added Greg KH and netdev)
What is the networking significance here?
> dev_<level> macros use a lot of repetitive string space.
>
> Eliminate the string prefixes and function arguments from all the macro uses
> and consolidate them in functions.
>
> This patchset saves about 60K.
>
> This implementation also adds the ability to use a struct va_format to
> emit a format string along with va_list arguments.
>
> This %pV implementation should not be used without a wrapper that
> does printf argument verification like the dev_<level> functions.
>
> Inspired a bit by Nick Andrew's patches and Linus' comments in December 2008
> http://lkml.org/lkml/2008/12/6/15
> http://lkml.org/lkml/2008/12/6/101
>
Looks like a reasonable approach, although I didn't check how much
additional stack the recursion will take. Bear in mind that printk()
can be called from super-deep contexts.
What would I need to do to make it recur more than once? Include a %pV
in a string, like dev_printk("%s", %%pV")?
next prev parent reply other threads:[~2010-03-04 22:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 6:21 [PATCH 0/2] Make functions of dev_<level> macros, recursive vsnprintf Joe Perches
2010-03-04 6:21 ` [PATCH 1/2] vsprintf: Recursive vsnprintf: Add "%pV", struct va_format Joe Perches
2010-03-04 6:21 ` [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level> macros to functions Joe Perches
2010-03-05 0:56 ` Andrew Morton
2010-03-05 1:00 ` Andrew Morton
2010-03-05 1:00 ` Andrew Morton
2010-03-05 2:46 ` Joe Perches
2010-03-04 6:27 ` [PATCH 1/2] vsprintf: Recursive vsnprintf: Add "%pV", struct va_format Joe Perches
2010-03-04 6:27 ` [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level> macros to functions Joe Perches
2010-03-04 22:38 ` Andrew Morton [this message]
2010-03-04 23:06 ` [RESEND PATCH 0/2] Make functions of dev_<level> macros, recursive vsnprintf Linus Torvalds
2010-03-06 21:36 ` Joe Perches
2010-03-06 22:03 ` Linus Torvalds
2010-03-06 22:30 ` Joe Perches
2010-03-06 22:52 ` Linus Torvalds
2010-03-06 22:57 ` Linus Torvalds
2010-03-06 23:35 ` Joe Perches
2010-03-06 23:46 ` Linus Torvalds
2010-03-06 23:48 ` Linus Torvalds
2010-03-06 23:57 ` Joe Perches
2010-03-06 23:58 ` Linus Torvalds
2010-03-07 1:10 ` [PATCH] vsprintf.c: Reduce sizeof struct printf_spec from 24 to 8 bytes Joe Perches
2010-03-07 2:03 ` Linus Torvalds
2010-03-07 2:24 ` Linus Torvalds
2010-03-07 2:33 ` [PATCH] vsprintf.c: Use noinline_for_stack Joe Perches
2010-03-08 23:39 ` Joe Perches
2010-03-13 0:25 ` Andrew Morton
2010-03-13 15:35 ` Linus Torvalds
2010-03-13 17:44 ` Joe Perches
2010-03-13 19:54 ` [PATCH] vsprintf.c: remove stack variable ksym from Joe Perches
2010-03-15 15:01 ` Paulo Marques
2010-03-15 15:01 ` Paulo Marques
-- strict thread matches above, loose matches on Subject: below --
2010-03-04 6:27 [RESEND PATCH 0/2] Make functions of dev_<level> macros, recursive vsnprintf Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304143837.af39845d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick@nick-andrew.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.