From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nick Andrew <nick@nick-andrew.net>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level> macros to functions
Date: Thu, 4 Mar 2010 17:00:30 -0800 [thread overview]
Message-ID: <20100304170030.f97c6630.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100304165609.20849b93.akpm@linux-foundation.org>
On Thu, 4 Mar 2010 16:56:09 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 3 Mar 2010 22:27:23 -0800 Joe Perches <joe@perches.com> wrote:
>
> > Save ~60k in a defconfig
> >
> > Use %pV and struct va_format
> > Format arguments are verified before printk
>
> Well that doesn't work very well.
>
> drivers/net/pcmcia/pcnet_cs.c:117: error: 'dev_info' redeclared as different kind of symbol
> include/linux/device.h:645: error: previous declaration of 'dev_info' was here
>
> there are lots of other dev_info's which will fail plus perhaps
> dev_err's, etc.
>
btw, this may be kludgeable aroundable by doing
int _dev_info(const struct device *dev, const char *fmt, ...);
#define dev_info(...) _dev_info(...)
which will use the preprocessor's separation of `foo' from `foo()' to
fix things up.
But it would be better to rename all those dev_info's to device_info or
whatever, IMO.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nick Andrew <nick@nick-andrew.net>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Subject: Re: [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level> macros to functions
Date: Thu, 4 Mar 2010 17:00:30 -0800 [thread overview]
Message-ID: <20100304170030.f97c6630.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100304165609.20849b93.akpm@linux-foundation.org>
On Thu, 4 Mar 2010 16:56:09 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 3 Mar 2010 22:27:23 -0800 Joe Perches <joe@perches.com> wrote:
>
> > Save ~60k in a defconfig
> >
> > Use %pV and struct va_format
> > Format arguments are verified before printk
>
> Well that doesn't work very well.
>
> drivers/net/pcmcia/pcnet_cs.c:117: error: 'dev_info' redeclared as different kind of symbol
> include/linux/device.h:645: error: previous declaration of 'dev_info' was here
>
> there are lots of other dev_info's which will fail plus perhaps
> dev_err's, etc.
>
btw, this may be kludgeable aroundable by doing
int _dev_info(const struct device *dev, const char *fmt, ...);
#define dev_info(...) _dev_info(...)
which will use the preprocessor's separation of `foo' from `foo()' to
fix things up.
But it would be better to rename all those dev_info's to device_info or
whatever, IMO.
next prev parent reply other threads:[~2010-03-05 1:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 6:21 [PATCH 0/2] Make functions of dev_<level> macros, recursive vsnprintf Joe Perches
2010-03-04 6:21 ` [PATCH 1/2] vsprintf: Recursive vsnprintf: Add "%pV", struct va_format Joe Perches
2010-03-04 6:21 ` [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level> macros to functions Joe Perches
2010-03-05 0:56 ` Andrew Morton
2010-03-05 1:00 ` Andrew Morton [this message]
2010-03-05 1:00 ` Andrew Morton
2010-03-05 2:46 ` Joe Perches
2010-03-04 6:27 ` [PATCH 1/2] vsprintf: Recursive vsnprintf: Add "%pV", struct va_format Joe Perches
2010-03-04 6:27 ` [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level> macros to functions Joe Perches
2010-03-04 22:38 ` [RESEND PATCH 0/2] Make functions of dev_<level> macros, recursive vsnprintf Andrew Morton
2010-03-04 23:06 ` Linus Torvalds
2010-03-06 21:36 ` Joe Perches
2010-03-06 22:03 ` Linus Torvalds
2010-03-06 22:30 ` Joe Perches
2010-03-06 22:52 ` Linus Torvalds
2010-03-06 22:57 ` Linus Torvalds
2010-03-06 23:35 ` Joe Perches
2010-03-06 23:46 ` Linus Torvalds
2010-03-06 23:48 ` Linus Torvalds
2010-03-06 23:57 ` Joe Perches
2010-03-06 23:58 ` Linus Torvalds
2010-03-07 1:10 ` [PATCH] vsprintf.c: Reduce sizeof struct printf_spec from 24 to 8 bytes Joe Perches
2010-03-07 2:03 ` Linus Torvalds
2010-03-07 2:24 ` Linus Torvalds
2010-03-07 2:33 ` [PATCH] vsprintf.c: Use noinline_for_stack Joe Perches
2010-03-08 23:39 ` Joe Perches
2010-03-13 0:25 ` Andrew Morton
2010-03-13 15:35 ` Linus Torvalds
2010-03-13 17:44 ` Joe Perches
2010-03-13 19:54 ` [PATCH] vsprintf.c: remove stack variable ksym from Joe Perches
2010-03-15 15:01 ` Paulo Marques
2010-03-15 15:01 ` Paulo Marques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304170030.f97c6630.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick@nick-andrew.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.