* [Bridge] [patch] bridge: cleanup: remove unneed check
@ 2010-03-06 11:14 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-06 11:14 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev, kernel-janitors, bridge, David S. Miller
We dereference "port" on the lines immediately before and immediately
after the test so port should hopefully never be null here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 2559fb5..8b25887 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -627,8 +627,8 @@ static void br_multicast_port_query_expired(unsigned long data)
struct net_bridge *br = port->br;
spin_lock(&br->multicast_lock);
- if (port && (port->state == BR_STATE_DISABLED ||
- port->state == BR_STATE_BLOCKING))
+ if (port->state == BR_STATE_DISABLED ||
+ port->state == BR_STATE_BLOCKING)
goto out;
if (port->multicast_startup_queries_sent <
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] bridge: cleanup: remove unneed check
@ 2010-03-06 11:14 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-06 11:14 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev, kernel-janitors, bridge, David S. Miller
We dereference "port" on the lines immediately before and immediately
after the test so port should hopefully never be null here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 2559fb5..8b25887 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -627,8 +627,8 @@ static void br_multicast_port_query_expired(unsigned long data)
struct net_bridge *br = port->br;
spin_lock(&br->multicast_lock);
- if (port && (port->state == BR_STATE_DISABLED ||
- port->state == BR_STATE_BLOCKING))
+ if (port->state == BR_STATE_DISABLED ||
+ port->state == BR_STATE_BLOCKING)
goto out;
if (port->multicast_startup_queries_sent <
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] bridge: cleanup: remove unneed check
@ 2010-03-06 11:14 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-06 11:14 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev, kernel-janitors, bridge, David S. Miller
We dereference "port" on the lines immediately before and immediately
after the test so port should hopefully never be null here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 2559fb5..8b25887 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -627,8 +627,8 @@ static void br_multicast_port_query_expired(unsigned long data)
struct net_bridge *br = port->br;
spin_lock(&br->multicast_lock);
- if (port && (port->state = BR_STATE_DISABLED ||
- port->state = BR_STATE_BLOCKING))
+ if (port->state = BR_STATE_DISABLED ||
+ port->state = BR_STATE_BLOCKING)
goto out;
if (port->multicast_startup_queries_sent <
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Bridge] [patch] bridge: cleanup: remove unneed check
2010-03-06 11:14 ` Dan Carpenter
@ 2010-03-06 12:20 ` Herbert Xu
-1 siblings, 0 replies; 8+ messages in thread
From: Herbert Xu @ 2010-03-06 12:20 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, kernel-janitors, bridge, David S. Miller
On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
> We dereference "port" on the lines immediately before and immediately
> after the test so port should hopefully never be null here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Yes this looks correct to me.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] bridge: cleanup: remove unneed check
@ 2010-03-06 12:20 ` Herbert Xu
0 siblings, 0 replies; 8+ messages in thread
From: Herbert Xu @ 2010-03-06 12:20 UTC (permalink / raw)
To: kernel-janitors
On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
> We dereference "port" on the lines immediately before and immediately
> after the test so port should hopefully never be null here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Yes this looks correct to me.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Bridge] [patch] bridge: cleanup: remove unneed check
2010-03-06 12:20 ` Herbert Xu
(?)
@ 2010-03-07 23:27 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-07 23:27 UTC (permalink / raw)
To: herbert; +Cc: netdev, kernel-janitors, bridge, error27
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 6 Mar 2010 20:20:32 +0800
> On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
>> We dereference "port" on the lines immediately before and immediately
>> after the test so port should hopefully never be null here.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Yes this looks correct to me.
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] bridge: cleanup: remove unneed check
@ 2010-03-07 23:27 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-07 23:27 UTC (permalink / raw)
To: herbert; +Cc: error27, shemminger, bridge, netdev, kernel-janitors
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 6 Mar 2010 20:20:32 +0800
> On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
>> We dereference "port" on the lines immediately before and immediately
>> after the test so port should hopefully never be null here.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Yes this looks correct to me.
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] bridge: cleanup: remove unneed check
@ 2010-03-07 23:27 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-03-07 23:27 UTC (permalink / raw)
To: herbert; +Cc: error27, shemminger, bridge, netdev, kernel-janitors
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 6 Mar 2010 20:20:32 +0800
> On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
>> We dereference "port" on the lines immediately before and immediately
>> after the test so port should hopefully never be null here.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Yes this looks correct to me.
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-03-07 23:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-06 11:14 [Bridge] [patch] bridge: cleanup: remove unneed check Dan Carpenter
2010-03-06 11:14 ` Dan Carpenter
2010-03-06 11:14 ` Dan Carpenter
2010-03-06 12:20 ` [Bridge] " Herbert Xu
2010-03-06 12:20 ` Herbert Xu
2010-03-07 23:27 ` [Bridge] " David Miller
2010-03-07 23:27 ` David Miller
2010-03-07 23:27 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.