From: Dan Carpenter <error27@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Dave Young <hidave.darkstar@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Roger Quadros <ext-roger.quadros@nokia.com>,
Bing Zhao <bzhao@marvell.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] bluetooth: debugfs changes use too much stack
Date: Sat, 06 Mar 2010 11:15:52 +0000 [thread overview]
Message-ID: <20100306111552.GK4958@bicker> (raw)
The original code would break with a 4K stack.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
This was compile tested only. Sorry about that.
diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index 1a79a6c..835758f 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -417,9 +417,11 @@ static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf,
struct hci_dev *hdev = file->private_data;
struct inquiry_cache *cache = &hdev->inq_cache;
struct inquiry_entry *e;
- char buf[4096];
+ char *buf;
int n = 0;
+ ssize_t ret;
+ buf = kmalloc(4096, GFP_KERNEL);
hci_dev_lock_bh(hdev);
for (e = cache->list; e; e = e->next) {
@@ -437,7 +439,10 @@ static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf,
hci_dev_unlock_bh(hdev);
- return simple_read_from_buffer(userbuf, count, ppos, buf, n);
+ ret = simple_read_from_buffer(userbuf, count, ppos, buf, n);
+ kfree(buf);
+
+ return ret;
}
static const struct file_operations inquiry_cache_fops = {
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Dave Young <hidave.darkstar@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Roger Quadros <ext-roger.quadros@nokia.com>,
Bing Zhao <bzhao@marvell.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] bluetooth: debugfs changes use too much stack
Date: Sat, 6 Mar 2010 14:15:52 +0300 [thread overview]
Message-ID: <20100306111552.GK4958@bicker> (raw)
The original code would break with a 4K stack.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
This was compile tested only. Sorry about that.
diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index 1a79a6c..835758f 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -417,9 +417,11 @@ static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf,
struct hci_dev *hdev = file->private_data;
struct inquiry_cache *cache = &hdev->inq_cache;
struct inquiry_entry *e;
- char buf[4096];
+ char *buf;
int n = 0;
+ ssize_t ret;
+ buf = kmalloc(4096, GFP_KERNEL);
hci_dev_lock_bh(hdev);
for (e = cache->list; e; e = e->next) {
@@ -437,7 +439,10 @@ static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf,
hci_dev_unlock_bh(hdev);
- return simple_read_from_buffer(userbuf, count, ppos, buf, n);
+ ret = simple_read_from_buffer(userbuf, count, ppos, buf, n);
+ kfree(buf);
+
+ return ret;
}
static const struct file_operations inquiry_cache_fops = {
next reply other threads:[~2010-03-06 11:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-06 11:15 Dan Carpenter [this message]
2010-03-06 11:15 ` [patch] bluetooth: debugfs changes use too much stack Dan Carpenter
2010-03-06 14:40 ` Jan Ceuleers
2010-03-06 14:40 ` Jan Ceuleers
2010-03-06 15:30 ` Dan Carpenter
2010-03-06 15:30 ` Dan Carpenter
2010-03-06 15:30 ` Dan Carpenter
2010-03-06 17:49 ` Marcel Holtmann
2010-03-06 17:49 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100306111552.GK4958@bicker \
--to=error27@gmail.com \
--cc=bzhao@marvell.com \
--cc=davem@davemloft.net \
--cc=ext-roger.quadros@nokia.com \
--cc=gregkh@suse.de \
--cc=hidave.darkstar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.