* batman: potential null dereference
@ 2010-03-08 13:07 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-03-08 13:07 UTC (permalink / raw)
To: kernel-janitors
drivers/staging/batman-adv/routing.c
88 } else if ((orig_node->router = NULL) && (neigh_node != NULL)) {
^^^^^^^^^^^^^^^^^^^^^^^^^
89
90 bat_dbg(DBG_ROUTES,
91 "Adding route towards: %pM (via %pM)\n",
92 orig_node->orig, neigh_node->addr);
93 hna_global_add_orig(orig_node, hna_buff, hna_buff_len);
94
95 /* route changed */
96 } else {
97 bat_dbg(DBG_ROUTES, "Changing route towards: %pM (now via %pM - was via %pM)\n",
orig_node->orig, neigh_node->addr, orig_node->router->addr);
^^^^^^^^^^^^^^^^^^^^^^^
98 }
This could fail if debugging is enabled and neigh_node is null.
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-08 13:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-08 13:07 batman: potential null dereference Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.