From: Jason Baron <jbaron@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Greg Banks" <gnb@melbourne.sgi.com>,
"André Goddard Rosa" <andre.goddard@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dynamic_debug: small clean up in ddebug_proc_write()
Date: Mon, 08 Mar 2010 15:51:33 +0000 [thread overview]
Message-ID: <20100308155132.GA2734@redhat.com> (raw)
In-Reply-To: <20100306105934.GA4958@bicker>
On Sat, Mar 06, 2010 at 01:59:34PM +0300, Dan Carpenter wrote:
> This the doesn't change behavior at all. In the original code, if nwords
> was zero then ddebug_parse_query() would return -EINVAL, now we just do
> it earlier.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
I guess it makes the code a little more readable.
Acked-by: Jason Baron <jbaron@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jason Baron <jbaron@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Greg Banks" <gnb@melbourne.sgi.com>,
"André Goddard Rosa" <andre.goddard@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dynamic_debug: small clean up in ddebug_proc_write()
Date: Mon, 8 Mar 2010 10:51:33 -0500 [thread overview]
Message-ID: <20100308155132.GA2734@redhat.com> (raw)
In-Reply-To: <20100306105934.GA4958@bicker>
On Sat, Mar 06, 2010 at 01:59:34PM +0300, Dan Carpenter wrote:
> This the doesn't change behavior at all. In the original code, if nwords
> was zero then ddebug_parse_query() would return -EINVAL, now we just do
> it earlier.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
I guess it makes the code a little more readable.
Acked-by: Jason Baron <jbaron@redhat.com>
next prev parent reply other threads:[~2010-03-08 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-06 10:59 [patch] dynamic_debug: small clean up in ddebug_proc_write() Dan Carpenter
2010-03-06 10:59 ` Dan Carpenter
2010-03-08 15:51 ` Jason Baron [this message]
2010-03-08 15:51 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308155132.GA2734@redhat.com \
--to=jbaron@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andre.goddard@gmail.com \
--cc=error27@gmail.com \
--cc=gnb@melbourne.sgi.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.