All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
	linux-next@vger.kernel.org
Subject: Re: [PATCH] i2c: update for semaphore to mutex conversion of devices
Date: Tue, 9 Mar 2010 11:39:50 +0100	[thread overview]
Message-ID: <20100309113950.48be08a1@hyperion.delvare> (raw)
In-Reply-To: <20100309213650.e22c9908.sfr@canb.auug.org.au>

On Tue, 9 Mar 2010 21:36:50 +1100, Stephen Rothwell wrote:
> Hi Jean,
> 
> On Tue, 9 Mar 2010 09:25:08 +0100 Jean Delvare <khali@linux-fr.org> wrote:
> >
> > Thanks for the reminder Stephen. I was only waiting for device_lock()
> > to become usable in mainline. Now that it happened, I will take the
> > patch above in my i2c tree, and send it to Linus in my next batch.
> 
> Thanks.  The include of mutex.h is not actually needed yet as Greg didn't
> send the semaphore to mutex change to Linus due to other issues.

It will never be needed, and I also removed the include of semaphore.h.
The beauty of the new API is that it hides the implementation details
from the caller!

>  The
> device_lock/unlock part would be useful, though for when the change does
> happen.

Of course.

-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
	linux-next@vger.kernel.org
Subject: Re: [PATCH] i2c: update for semaphore to mutex conversion of  devices
Date: Tue, 9 Mar 2010 11:39:50 +0100	[thread overview]
Message-ID: <20100309113950.48be08a1@hyperion.delvare> (raw)
In-Reply-To: <20100309213650.e22c9908.sfr@canb.auug.org.au>

On Tue, 9 Mar 2010 21:36:50 +1100, Stephen Rothwell wrote:
> Hi Jean,
> 
> On Tue, 9 Mar 2010 09:25:08 +0100 Jean Delvare <khali@linux-fr.org> wrote:
> >
> > Thanks for the reminder Stephen. I was only waiting for device_lock()
> > to become usable in mainline. Now that it happened, I will take the
> > patch above in my i2c tree, and send it to Linus in my next batch.
> 
> Thanks.  The include of mutex.h is not actually needed yet as Greg didn't
> send the semaphore to mutex change to Linus due to other issues.

It will never be needed, and I also removed the include of semaphore.h.
The beauty of the new API is that it hides the implementation details
from the caller!

>  The
> device_lock/unlock part would be useful, though for when the change does
> happen.

Of course.

-- 
Jean Delvare

  reply	other threads:[~2010-03-09 10:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 23:28 [PATCH] i2c: update for semaphore to mutex conversion of devices Stephen Rothwell
2010-03-08 23:59 ` Greg KH
2010-03-09  1:50   ` Stephen Rothwell
2010-03-09  2:27     ` Greg KH
2010-03-09 16:04   ` Peter Zijlstra
2010-03-09  8:25 ` Jean Delvare
2010-03-09 10:36   ` Stephen Rothwell
2010-03-09 10:39     ` Jean Delvare [this message]
2010-03-09 10:39       ` Jean Delvare
2010-03-09 10:47       ` Stephen Rothwell
2010-03-09 10:47         ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100309113950.48be08a1@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.