From: Greg KH <gregkh@suse.de>
To: Valdis.Kletnieks@vt.edu
Cc: Tejun Heo <tj@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: odd lockdep messages
Date: Tue, 9 Mar 2010 06:18:01 -0800 [thread overview]
Message-ID: <20100309141801.GB28606@suse.de> (raw)
In-Reply-To: <5221.1268124692@localhost>
On Tue, Mar 09, 2010 at 03:51:32AM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 09 Mar 2010 15:44:28 +0900, Tejun Heo said:
>
> (adding some cc: from the other 'BUG: key %p not found' thread)
>
> > Hmm... the original percpu address check wasn't correct but wasn't too
> > far off either so it wouldn't be surprising nothing triggered it.
> > Yeap, stack trace should tell us where the address is coming from.
>
> OK, I stuck in a dump_stack(), and took out the built-in firmware so we'd
> get 4 hits rather than 2. What we got:
>
> [ 1.007551] BUG: key ffff88011c8b7d00 not in .data!
> [ 1.007657] Pid: 1, comm: swapper Not tainted 2.6.33-mmotm0304 #5
> [ 1.007763] Call Trace:
> [ 1.007869] [<ffffffff81061f63>] lockdep_init_map+0xab/0x10d
> [ 1.007977] [<ffffffff81135d83>] sysfs_add_file_mode+0x61/0xa7
> [ 1.008095] [<ffffffff81135dd5>] sysfs_add_file+0xc/0xe
> [ 1.008201] [<ffffffff81135e95>] sysfs_create_file+0x5a/0x63
> [ 1.008320] [<ffffffff812fb51c>] device_create_file+0x14/0x16
> [ 1.008428] [<ffffffff813d9942>] thermal_zone_device_register+0x3d2/0x63c
> [ 1.008538] [<ffffffff81264be9>] acpi_thermal_add+0x2dc/0x59f
> [ 1.008646] [<ffffffff8123a50b>] acpi_device_probe+0x4b/0x11d
> [ 1.008753] [<ffffffff812fdd25>] driver_probe_device+0xd5/0x166
> [ 1.008861] [<ffffffff812fde12>] __driver_attach+0x5c/0x80
> [ 1.008968] [<ffffffff812fddb6>] ? __driver_attach+0x0/0x80
> [ 1.009079] [<ffffffff812fddb6>] ? __driver_attach+0x0/0x80
> [ 1.009185] [<ffffffff812fd31f>] bus_for_each_dev+0x54/0x89
> [ 1.009301] [<ffffffff812fdb66>] driver_attach+0x19/0x1b
> [ 1.009407] [<ffffffff812fd7b1>] bus_add_driver+0xb4/0x203
> [ 1.009513] [<ffffffff812fe10f>] driver_register+0xb8/0x129
> [ 1.009621] [<ffffffff81b4b7a0>] ? acpi_thermal_init+0x0/0x7b
> [ 1.009727] [<ffffffff8123af12>] acpi_bus_register_driver+0x3e/0x40
> [ 1.009835] [<ffffffff81b4b7f9>] acpi_thermal_init+0x59/0x7b
> [ 1.009942] [<ffffffff810001ef>] do_one_initcall+0x59/0x14e
> [ 1.010064] [<ffffffff81b2c687>] kernel_init+0x14d/0x1d7
> [ 1.010171] [<ffffffff810033d4>] kernel_thread_helper+0x4/0x10
> [ 1.010289] [<ffffffff81584040>] ? restore_args+0x0/0x30
> [ 1.010394] [<ffffffff81b2c53a>] ? kernel_init+0x0/0x1d7
> [ 1.010500] [<ffffffff810033d0>] ? kernel_thread_helper+0x0/0x10
>
> [ 1.010607] BUG: key ffff88011c8b7d48 not in .data!
> [ 1.010711] Pid: 1, comm: swapper Not tainted 2.6.33-mmotm0304 #5
> [ 1.010817] Call Trace:
> [ 1.010919] [<ffffffff81061f63>] lockdep_init_map+0xab/0x10d
> [ 1.011030] [<ffffffff81135d83>] sysfs_add_file_mode+0x61/0xa7
> [ 1.011138] [<ffffffff81135dd5>] sysfs_add_file+0xc/0xe
> [ 1.011243] [<ffffffff81135e95>] sysfs_create_file+0x5a/0x63
> [ 1.011360] [<ffffffff812fb51c>] device_create_file+0x14/0x16
> [ 1.011467] [<ffffffff813d99c1>] thermal_zone_device_register+0x451/0x63c
> [ 1.011576] [<ffffffff81264be9>] acpi_thermal_add+0x2dc/0x59f
> [ 1.011683] [<ffffffff8123a50b>] acpi_device_probe+0x4b/0x11d
> [ 1.011790] [<ffffffff812fdd25>] driver_probe_device+0xd5/0x166
> [ 1.011897] [<ffffffff812fde12>] __driver_attach+0x5c/0x80
> [ 1.012003] [<ffffffff812fddb6>] ? __driver_attach+0x0/0x80
> [ 1.012114] [<ffffffff812fddb6>] ? __driver_attach+0x0/0x80
> [ 1.012221] [<ffffffff812fd31f>] bus_for_each_dev+0x54/0x89
> [ 1.012340] [<ffffffff812fdb66>] driver_attach+0x19/0x1b
> [ 1.012446] [<ffffffff812fd7b1>] bus_add_driver+0xb4/0x203
> [ 1.012553] [<ffffffff812fe10f>] driver_register+0xb8/0x129
> [ 1.012659] [<ffffffff81b4b7a0>] ? acpi_thermal_init+0x0/0x7b
> [ 1.012766] [<ffffffff8123af12>] acpi_bus_register_driver+0x3e/0x40
> [ 1.012874] [<ffffffff81b4b7f9>] acpi_thermal_init+0x59/0x7b
> [ 1.012980] [<ffffffff810001ef>] do_one_initcall+0x59/0x14e
> [ 1.013092] [<ffffffff81b2c687>] kernel_init+0x14d/0x1d7
> [ 1.013197] [<ffffffff810033d4>] kernel_thread_helper+0x4/0x10
> [ 1.013314] [<ffffffff81584040>] ? restore_args+0x0/0x30
> [ 1.013421] [<ffffffff81b2c53a>] ? kernel_init+0x0/0x1d7
> [ 1.013526] [<ffffffff810033d0>] ? kernel_thread_helper+0x0/0x10
>
> [ 2.859634] BUG: key ffff88011fe16270 not in .data!
> [ 2.859654] Pid: 828, comm: firmware/iwlwif Not tainted 2.6.33-mmotm0304 #5
> [ 2.859656] Call Trace:
> [ 2.859665] [<ffffffff81061f63>] lockdep_init_map+0xab/0x10d
> [ 2.859669] [<ffffffff81135d83>] sysfs_add_file_mode+0x61/0xa7
> [ 2.859672] [<ffffffff81135dd5>] sysfs_add_file+0xc/0xe
> [ 2.859675] [<ffffffff81137f08>] sysfs_create_bin_file+0x5a/0x63
> [ 2.859680] [<ffffffff81303a0f>] _request_firmware+0x421/0x431
> [ 2.859683] [<ffffffff81303a1f>] ? request_firmware_work_func+0x0/0x63
> [ 2.859686] [<ffffffff81303a59>] request_firmware_work_func+0x3a/0x63
> [ 2.859690] [<ffffffff81051d87>] kthread+0x7a/0x82
> [ 2.859694] [<ffffffff810033d4>] kernel_thread_helper+0x4/0x10
> [ 2.859699] [<ffffffff81584040>] ? restore_args+0x0/0x30
> [ 2.859702] [<ffffffff81051d0d>] ? kthread+0x0/0x82
> [ 2.859704] [<ffffffff810033d0>] ? kernel_thread_helper+0x0/0x10
>
> [ 11.534112] BUG: key ffff88011fe16270 not in .data!
> [ 11.534116] Pid: 1556, comm: firmware/iwlwif Not tainted 2.6.33-mmotm0304 #5
> [ 11.534118] Call Trace:
> [ 11.534128] [<ffffffff81061f63>] lockdep_init_map+0xab/0x10d
> [ 11.534133] [<ffffffff81135d83>] sysfs_add_file_mode+0x61/0xa7
> [ 11.534137] [<ffffffff81135dd5>] sysfs_add_file+0xc/0xe
> [ 11.534141] [<ffffffff81137f08>] sysfs_create_bin_file+0x5a/0x63
> [ 11.534151] [<ffffffff81303a1f>] ? request_firmware_work_func+0x0/0x63
> [ 11.534147] [<ffffffff81303a0f>] _request_firmware+0x421/0x431
> [ 11.534154] [<ffffffff81303a59>] request_firmware_work_func+0x3a/0x63
> [ 11.534159] [<ffffffff81051d87>] kthread+0x7a/0x82
> [ 11.534164] [<ffffffff810033d4>] kernel_thread_helper+0x4/0x10
> [ 11.534169] [<ffffffff81584040>] ? restore_args+0x0/0x30
> [ 11.534173] [<ffffffff81051d0d>] ? kthread+0x0/0x82
> [ 11.534176] [<ffffffff810033d0>] ? kernel_thread_helper+0x0/0x10
>
> So yeah, this looks like more sysfs breakage.
It is due to sysfs, but it is because we forgot to proper initialize a
sysfs attribute somewhere. Nothing is "broken" here, the system still
works properly.
Eric, care to look into this one as well?
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-09 14:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 18:30 odd lockdep messages Valdis.Kletnieks
2010-03-08 18:43 ` Peter Zijlstra
2010-03-08 20:00 ` Valdis.Kletnieks
2010-03-09 1:54 ` Tejun Heo
2010-03-09 6:27 ` Valdis.Kletnieks
2010-03-09 6:44 ` Tejun Heo
2010-03-09 8:51 ` Valdis.Kletnieks
2010-03-09 14:18 ` Greg KH [this message]
2010-03-09 9:12 ` [PATCH] percpu,lockdep: implement and use is_static_percpu_address() Tejun Heo
2010-03-09 11:25 ` Peter Zijlstra
2010-03-09 11:42 ` Tejun Heo
2010-03-09 11:46 ` Tejun Heo
2010-03-09 11:52 ` Peter Zijlstra
2010-03-10 9:56 ` [PATCH 1/2] module: encapsulate percpu handling better and record percpu_size Tejun Heo
2010-03-10 9:57 ` [PATCH 2/2] percpu,module: implement and use is_kernel/module_percpu_address() Tejun Heo
2010-03-10 10:42 ` Peter Zijlstra
2010-03-29 8:26 ` [PATCH 1/2] module: encapsulate percpu handling better and record percpu_size Rusty Russell
2010-03-29 14:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309141801.GB28606@suse.de \
--to=gregkh@suse.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.