All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Update i_blocks in reflink operations.
Date: Tue, 9 Mar 2010 17:43:52 -0800	[thread overview]
Message-ID: <20100310014352.GL6914@mail.oracle.com> (raw)
In-Reply-To: <1268111579-8600-1-git-send-email-tao.ma@oracle.com>

On Tue, Mar 09, 2010 at 01:12:59PM +0800, Tao Ma wrote:
> In reflink, we need to upate i_blocks for the target inode.
> 
> Reported-by: Jie Liu <jeff.liu@oracle.com>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
> ---
>  fs/ocfs2/refcounttree.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
> index 9e96921..f4aad88 100644
> --- a/fs/ocfs2/refcounttree.c
> +++ b/fs/ocfs2/refcounttree.c
> @@ -4075,6 +4075,7 @@ static int ocfs2_complete_reflink(struct inode *s_inode,
>  	OCFS2_I(t_inode)->ip_dyn_features = OCFS2_I(s_inode)->ip_dyn_features;
>  	spin_unlock(&OCFS2_I(t_inode)->ip_lock);
>  	i_size_write(t_inode, size);
> +	t_inode->i_blocks = ocfs2_inode_sector_count(t_inode);

	Curiously, why wouldn't it just be s_inode->i_blocks?

Joel

-- 

Life's Little Instruction Book #451

	"Don't be afraid to say, 'I'm sorry.'"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

  parent reply	other threads:[~2010-03-10  1:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09  5:12 [Ocfs2-devel] [PATCH] ocfs2: Update i_blocks in reflink operations Tao Ma
2010-03-09  9:33 ` jeff.liu
2010-03-10  1:43 ` Joel Becker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-10  1:56 Tao Ma
2010-03-17 19:29 ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100310014352.GL6914@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.