From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Voipac PXA270
Date: Wed, 10 Mar 2010 16:20:16 +0100 [thread overview]
Message-ID: <201003101620.17501.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100310133529.GK28972@buzzloop.caiaq.de>
Dne St 10. b?ezna 2010 14:35:29 Daniel Mack napsal(a):
> On Wed, Mar 10, 2010 at 12:37:26PM +0100, Marek Vasut wrote:
> > Dne St 10. b?ezna 2010 07:18:40 Mike Rapoport napsal(a):
> > > Do these defines really deserve dedicated .h file? Why cannot they live
> > > in the arch/arm/mach-pxa/vpac270.c?
> >
> > I'm not moving this in. I dont want to polute the .c file with stuff that
> > should obviously go into the header file. Besides there'll be more GPIOs
> > defined and that'd make the .c file less readable, which I want to avoid.
>
> The question is - are they shared? If they're not and will never be used
> by anything else then this .c file, I'd also vote for not having an
> extra header file for them.
>
> Daniel
>
Yes, they are used in the PCMCIA driver. And I'd rather avoid having GPIO
definitions scattered across multiple files.
next prev parent reply other threads:[~2010-03-10 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 1:47 [PATCH] Voipac PXA270 Marek Vasut
2010-03-10 6:18 ` Mike Rapoport
2010-03-10 11:37 ` Marek Vasut
2010-03-10 13:35 ` Daniel Mack
2010-03-10 15:20 ` Marek Vasut [this message]
2010-03-22 2:10 ` Eric Miao
2010-03-23 13:21 ` Baurzhan Ismagulov
2010-03-23 14:07 ` Daniel Mack
2010-03-23 15:45 ` Baurzhan Ismagulov
2010-03-22 2:21 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003101620.17501.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.