All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Julia Lawall <julia@diku.dk>,
	linux-kernel@vger.kernel.org, gregkh@suse.de,
	kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: smatch_scripts/whitespace_only.sh
Date: Thu, 11 Mar 2010 09:59:40 +0000	[thread overview]
Message-ID: <20100311095940.GK6321@bicker> (raw)
In-Reply-To: <1268244709.1545.392.camel@Joe-Laptop.home>

On Wed, Mar 10, 2010 at 10:11:49AM -0800, Joe Perches wrote:
> On Wed, 2010-03-10 at 15:38 +0100, Julia Lawall wrote:
> > > > On Wed, 10 Mar 2010, Dan Carpenter wrote:
> > > > > I wrote a script to check that a patch only changes white space.
> 
> Perhaps you could use #define __LINE__ 0 to avoid
> any vertical line position comparison checks?
> 

I tried something similar to that at first but I found that line 
numbers were used in other ways.  In the end, I added a -no-lineno to
sparse so it thinks everything is on line 123456.

It might be better to just right a perl script that strips out all the
whitespace and compares the result blobs before and after the patch.  
That would handle the #if 0 code as well.

regards,
dan carpenter

> > Maybe checkpatch could be changed to not complain about > 80 characters 
> > when the line contains a string?
> 
> That's been at least partially done in commit
> 691e669ba8c64d31ac08d87b1751e6acfa3ff65e

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Julia Lawall <julia@diku.dk>,
	linux-kernel@vger.kernel.org, gregkh@suse.de,
	kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: smatch_scripts/whitespace_only.sh
Date: Thu, 11 Mar 2010 12:59:40 +0300	[thread overview]
Message-ID: <20100311095940.GK6321@bicker> (raw)
In-Reply-To: <1268244709.1545.392.camel@Joe-Laptop.home>

On Wed, Mar 10, 2010 at 10:11:49AM -0800, Joe Perches wrote:
> On Wed, 2010-03-10 at 15:38 +0100, Julia Lawall wrote:
> > > > On Wed, 10 Mar 2010, Dan Carpenter wrote:
> > > > > I wrote a script to check that a patch only changes white space.
> 
> Perhaps you could use #define __LINE__ 0 to avoid
> any vertical line position comparison checks?
> 

I tried something similar to that at first but I found that line 
numbers were used in other ways.  In the end, I added a -no-lineno to
sparse so it thinks everything is on line 123456.

It might be better to just right a perl script that strips out all the
whitespace and compares the result blobs before and after the patch.  
That would handle the #if 0 code as well.

regards,
dan carpenter

> > Maybe checkpatch could be changed to not complain about > 80 characters 
> > when the line contains a string?
> 
> That's been at least partially done in commit
> 691e669ba8c64d31ac08d87b1751e6acfa3ff65e

  reply	other threads:[~2010-03-11  9:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 10:12 smatch_scripts/whitespace_only.sh Dan Carpenter
2010-03-10 10:12 ` smatch_scripts/whitespace_only.sh Dan Carpenter
2010-03-10 10:14 ` smatch_scripts/whitespace_only.sh Julia Lawall
2010-03-10 10:14   ` smatch_scripts/whitespace_only.sh Julia Lawall
2010-03-10 14:27   ` smatch_scripts/whitespace_only.sh Dan Carpenter
2010-03-10 14:27     ` smatch_scripts/whitespace_only.sh Dan Carpenter
2010-03-10 14:38     ` smatch_scripts/whitespace_only.sh Julia Lawall
2010-03-10 14:38       ` smatch_scripts/whitespace_only.sh Julia Lawall
2010-03-10 18:11       ` smatch_scripts/whitespace_only.sh Joe Perches
2010-03-10 18:11         ` smatch_scripts/whitespace_only.sh Joe Perches
2010-03-11  9:59         ` Dan Carpenter [this message]
2010-03-11  9:59           ` smatch_scripts/whitespace_only.sh Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100311095940.GK6321@bicker \
    --to=error27@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=joe@perches.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.