From: Johannes Weiner <hannes@cmpxchg.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] MEMORY MANAGEMENT: Remove deprecated memclear_highpage_flush().
Date: Thu, 11 Mar 2010 15:42:43 +0100 [thread overview]
Message-ID: <20100311144243.GA28203@cmpxchg.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1003110847220.6408@localhost>
On Thu, Mar 11, 2010 at 08:49:21AM -0500, Robert P. J. Day wrote:
>
> Since this routine is all of static, deprecated and unreferenced, it
> seems safe to delete it.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index 74152c0..c77f913 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -173,12 +173,6 @@ static inline void zero_user(struct page *page,
> zero_user_segments(page, start, start + size, 0, 0);
> }
>
> -static inline void __deprecated memclear_highpage_flush(struct page *page,
> - unsigned int offset, unsigned int size)
> -{
> - zero_user(page, offset, size);
> -}
> -
> #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
>
> static inline void copy_user_highpage(struct page *to, struct page *from,
>
> ========================================================================
> Robert P. J. Day Waterloo, Ontario, CANADA
>
> Linux Consulting, Training and Kernel Pedantry.
>
> Web page: http://crashcourse.ca
> Twitter: http://twitter.com/rpjday
> ========================================================================
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] MEMORY MANAGEMENT: Remove deprecated memclear_highpage_flush().
Date: Thu, 11 Mar 2010 15:42:43 +0100 [thread overview]
Message-ID: <20100311144243.GA28203@cmpxchg.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1003110847220.6408@localhost>
On Thu, Mar 11, 2010 at 08:49:21AM -0500, Robert P. J. Day wrote:
>
> Since this routine is all of static, deprecated and unreferenced, it
> seems safe to delete it.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index 74152c0..c77f913 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -173,12 +173,6 @@ static inline void zero_user(struct page *page,
> zero_user_segments(page, start, start + size, 0, 0);
> }
>
> -static inline void __deprecated memclear_highpage_flush(struct page *page,
> - unsigned int offset, unsigned int size)
> -{
> - zero_user(page, offset, size);
> -}
> -
> #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
>
> static inline void copy_user_highpage(struct page *to, struct page *from,
>
> ========================================================================
> Robert P. J. Day Waterloo, Ontario, CANADA
>
> Linux Consulting, Training and Kernel Pedantry.
>
> Web page: http://crashcourse.ca
> Twitter: http://twitter.com/rpjday
> ========================================================================
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-11 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 13:49 [PATCH] MEMORY MANAGEMENT: Remove deprecated memclear_highpage_flush() Robert P. J. Day
2010-03-11 13:49 ` Robert P. J. Day
2010-03-11 14:42 ` Johannes Weiner [this message]
2010-03-11 14:42 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311144243.GA28203@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.