All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] sched: remove some dead code
@ 2010-03-15  8:21 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2010-03-15  8:21 UTC (permalink / raw)
  To: Dhaval Giani
  Cc: Thomas Gleixner, Kay Sievers, Ingo Molnar, Greg Kroah-Hartman,
	linux-kernel, kernel-janitors

This was left over from "7c9414385e sched: Remove USER_SCHED"

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/user.c b/kernel/user.c
index 766467b..ec3b222 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
 
 	return up;
 
-	put_user_ns(new->user_ns);
-	kmem_cache_free(uid_cachep, new);
 out_unlock:
 	return NULL;
 }

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [patch] sched: remove some dead code
@ 2010-03-15  8:21 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2010-03-15  8:21 UTC (permalink / raw)
  To: Dhaval Giani
  Cc: Thomas Gleixner, Kay Sievers, Ingo Molnar, Greg Kroah-Hartman,
	linux-kernel, kernel-janitors

This was left over from "7c9414385e sched: Remove USER_SCHED"

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/user.c b/kernel/user.c
index 766467b..ec3b222 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
 
 	return up;
 
-	put_user_ns(new->user_ns);
-	kmem_cache_free(uid_cachep, new);
 out_unlock:
 	return NULL;
 }

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [patch] sched: remove some dead code
  2010-03-15  8:21 ` Dan Carpenter
@ 2010-03-15 12:54   ` Dhaval Giani
  -1 siblings, 0 replies; 5+ messages in thread
From: Dhaval Giani @ 2010-03-15 12:54 UTC (permalink / raw)
  To: Dan Carpenter, Dhaval Giani, Thomas Gleixner, Kay Sievers,
	Ingo Molnar, Greg Kroah-Hartman, linux-kernel, kernel-janitors

On Mon, Mar 15, 2010 at 9:21 AM, Dan Carpenter <error27@gmail.com> wrote:
> This was left over from "7c9414385e sched: Remove USER_SCHED"
>

Quite surprising I missed that. Thanks for catching it.

> Signed-off-by: Dan Carpenter <error27@gmail.com>
>

Acked-by: Dhaval Giani <dhaval.giani@gmail.com>

> diff --git a/kernel/user.c b/kernel/user.c
> index 766467b..ec3b222 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
>
>        return up;
>
> -       put_user_ns(new->user_ns);
> -       kmem_cache_free(uid_cachep, new);
>  out_unlock:
>        return NULL;
>  }
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch] sched: remove some dead code
@ 2010-03-15 12:54   ` Dhaval Giani
  0 siblings, 0 replies; 5+ messages in thread
From: Dhaval Giani @ 2010-03-15 12:54 UTC (permalink / raw)
  To: Dan Carpenter, Dhaval Giani, Thomas Gleixner, Kay Sievers,
	Ingo Molnar, Greg Kroah-Hartman, linux-kernel, kernel-janitors

On Mon, Mar 15, 2010 at 9:21 AM, Dan Carpenter <error27@gmail.com> wrote:
> This was left over from "7c9414385e sched: Remove USER_SCHED"
>

Quite surprising I missed that. Thanks for catching it.

> Signed-off-by: Dan Carpenter <error27@gmail.com>
>

Acked-by: Dhaval Giani <dhaval.giani@gmail.com>

> diff --git a/kernel/user.c b/kernel/user.c
> index 766467b..ec3b222 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
>
>        return up;
>
> -       put_user_ns(new->user_ns);
> -       kmem_cache_free(uid_cachep, new);
>  out_unlock:
>        return NULL;
>  }
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tip:sched/core] sched: Remove some dead code
  2010-03-15  8:21 ` Dan Carpenter
  (?)
  (?)
@ 2010-03-16 14:47 ` tip-bot for Dan Carpenter
  -1 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Dan Carpenter @ 2010-03-16 14:47 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, dhaval.giani, hpa, mingo, kay.sievers, error27,
	gregkh, tglx, mingo

Commit-ID:  6427462bfa50f50dc6c088c07037264fcc73eca1
Gitweb:     http://git.kernel.org/tip/6427462bfa50f50dc6c088c07037264fcc73eca1
Author:     Dan Carpenter <error27@gmail.com>
AuthorDate: Mon, 15 Mar 2010 11:21:48 +0300
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 16 Mar 2010 11:05:44 +0100

sched: Remove some dead code

This was left over from "7c9414385e sched: Remove USER_SCHED"

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
LKML-Reference: <20100315082148.GD18181@bicker>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/user.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/user.c b/kernel/user.c
index 766467b..ec3b222 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
 
 	return up;
 
-	put_user_ns(new->user_ns);
-	kmem_cache_free(uid_cachep, new);
 out_unlock:
 	return NULL;
 }

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-03-16 14:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15  8:21 [patch] sched: remove some dead code Dan Carpenter
2010-03-15  8:21 ` Dan Carpenter
2010-03-15 12:54 ` Dhaval Giani
2010-03-15 12:54   ` Dhaval Giani
2010-03-16 14:47 ` [tip:sched/core] sched: Remove " tip-bot for Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.