All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Stefani Seibold <stefani@seibold.net>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@suse.de>
Subject: [patch] libsrp: remove dead code
Date: Mon, 15 Mar 2010 08:25:56 +0000	[thread overview]
Message-ID: <20100315082556.GI18181@bicker> (raw)

There was a stray kfree() left over from:
4546548789 kfifo: move struct kfifo in place

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/scsi/libsrp.c b/drivers/scsi/libsrp.c
index 2277516..c06eaeb 100644
--- a/drivers/scsi/libsrp.c
+++ b/drivers/scsi/libsrp.c
@@ -67,7 +67,6 @@ static int srp_iu_pool_alloc(struct srp_queue *q, size_t max,
 	}
 	return 0;
 
-	kfree(q->items);
 free_pool:
 	kfree(q->pool);
 	return -ENOMEM;

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Stefani Seibold <stefani@seibold.net>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@suse.de>
Subject: [patch] libsrp: remove dead code
Date: Mon, 15 Mar 2010 11:25:56 +0300	[thread overview]
Message-ID: <20100315082556.GI18181@bicker> (raw)

There was a stray kfree() left over from:
4546548789 kfifo: move struct kfifo in place

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/scsi/libsrp.c b/drivers/scsi/libsrp.c
index 2277516..c06eaeb 100644
--- a/drivers/scsi/libsrp.c
+++ b/drivers/scsi/libsrp.c
@@ -67,7 +67,6 @@ static int srp_iu_pool_alloc(struct srp_queue *q, size_t max,
 	}
 	return 0;
 
-	kfree(q->items);
 free_pool:
 	kfree(q->pool);
 	return -ENOMEM;

             reply	other threads:[~2010-03-15  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15  8:25 Dan Carpenter [this message]
2010-03-15  8:25 ` [patch] libsrp: remove dead code Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315082556.GI18181@bicker \
    --to=error27@gmail.com \
    --cc=James.Bottomley@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.